David MARKEY
David MARKEY
Love it!
Alternatively, you could also try out Pennyworth to handle route composition and mounting. With Pennyworth, you can implement your service methods directly with strong types and provide annotations to specify...
Pennyworth is not released as a package yet. You can find more info here: * https://github.com/d-markey/pennyworth * https://github.com/d-markey/pennyworth_builder * https://github.com/d-markey/pennyworth_sample
Trying to write a proper test but I can't get it to work though. I closed my PR until the test code is there but I won't have time before...
BTW I would like to avoid using resolveSymbolicLinks() when checking for the target file path. Having the possibility to symlink a file for download sounds interesting IMHO.
@seceba thanks for your feedback, I've modified my PR to handle all ".." segments and now the test passes.
Apart from one remark, I think this is good to go.
I left it in the code review, namely: If for some reason parsing fails (eg. the verb used in the request does not match any of the Method values), this...
Thanks @aadarshadhakalg. I'm pondering though, the min SDK number in the pubspec file hasn't been updated. I guess if a user runs on Dart < 2.15 this would not work....
No objection here :-)