Daniel Jeffery
Daniel Jeffery
## Description Restrict character limit of condition down to 50 characters. Left the patterns as they were. ## References https://github.com/openfga/language/issues/319 ## Review Checklist - [ ] I have clicked on...
Add test where `a from b` is directly assigned but contains `user:*` or `user#relation` errors out
> Add a test that ensures that if b in the case of a from b is directly assigned but contains user:* or user#relation that we error out too. e.g....
Go through: - https://github.com/openfga/api/blob/c96ec773cae9caf2a9536856bf1fa206a42ef7ef/openfga/v1/openfga.proto#L92 - https://github.com/openfga/api/blob/c96ec773cae9caf2a9536856bf1fa206a42ef7ef/openfga/v1/authzmodel.proto#L137 - https://github.com/openfga/language/blob/main/pkg/go/validation/validation-rules.go#L13 > And make sure the validation is consistent for all three? Let's make it {1,50}
- https://github.com/openfga/language/issues/68 Update `relation used inside from allows only direct relation` to the API exception `the 'group#org' relation is referenced in at least one tupleset and thus must be a...
Implemented advice of `Semgrep`, and it resulted in either testing complications where the suite would hang indefinitely on my machine, or a need to do a refactor in order to...
Currently each language has its own validation rules and implementation. This means updating the regex rules will require a change and release of every pkg. Likewise, the schema for validation...
In a follow-up PR, let's pre-compute these. The language representation of the model should have all the relations per type precomputed so as to improve performance. _Originally posted by @rhamzeh...
- Instead of directly including CEL grammar, we can split it out and import the definitions - Update tests with new token ordering Previous WIP is here: https://github.com/openfga/language/pull/104
When time allows, we can build off the following PR and improve the tokenization of the lexer and parser. https://github.com/openfga/language/pull/22 Core problem stopping this is the character chosen to trigger...