Daniel Brendgen-Czerwonk comments

Results 20 comments of


                                            Daniel Brendgen-Czerwonk

NSID inclusion

Hi, i will have a look at the closed PR and consider merging

IPv4 or v6

Thanks for the feedback. We consider this feature requst for the next release

Can we get a new build?

Totally agree. I will trigger a new build today

bfd sessions

This is not implemented yet. Can you provide (anonymized) output for ``birdc show bfd sessions``?

bfd sessions

Feature is included in Version 1.4 wich was released a few moments ago.

Can't install junos_exporter

There were 2 tags of version 0.7.x which matched the vX.X.X version scheme. These were used when requested latest. I just deleted the tags so ``@latest`` uses the master branch...

bfd sessions

[PR](#97) was merged and new tag was created

install fails due to dependency change of prometheus/common/log

Hi, the log package of prometheus was deprecated. I updated the modules specifications and replaced it by logrus in 6196ebd1e7387aa7dd7ca15a2d431d6b1853ef99

feat: allow for a kubernetes endpoint resolver

Looks good so far. I am not against a breaking change in 1.2.x. But if we do and get rid of the temporary solution we needed to this time, i...

Move <rpc-reply> unpacking to RPC client

I quite like the idea. Also makes the existing code more readable due to less chaining. Please go ahead if you like. Happy to review and merge when done.