ping_exporter icon indicating copy to clipboard operation
ping_exporter copied to clipboard

feat: allow for a kubernetes endpoint resolver

Open daveoy opened this issue 11 months ago • 2 comments

relates to #130

daveoy avatar Mar 21 '25 21:03 daveoy

relates to #129

daveoy avatar Mar 21 '25 22:03 daveoy

Looks good so far. I am not against a breaking change in 1.2.x. But if we do and get rid of the temporary solution we needed to this time, i would strongly argue to use a more structured config path. I have something like this in mind. In my opinion it is not clear that everything else than host are labels. If we do the breaking change with a custom unmarshaller, i would suggest something like in k8s.

targets:
  - host: google.com
    labels:
       my_label: my_value

This would also allow extensibility if we want to add something host specific beside labels in the future

What do you think?

czerwonk avatar Aug 25 '25 14:08 czerwonk