czaloumis
czaloumis
In which component must I look exactly?
@majinghe, I reviewed your commit—really nice that we can now configure imagePullSecrets via the Helm chart! However, I think it would be better to also support referencing an existing imagePullSecret...
Tested on on-prem Kubernetes. The Deployment and StatefulSet now support a list of imagePullSecrets defined in values.yaml.
@majinghe , I'm working on it, I'll let you know once done.
@majinghe, Tested on on-prem Kubernetes cluster and confirmed it works in both cases: - Using predefined imagePullSecrets - Creating one automatically from the imageRegistryCredentials implementation Also verified compatibility with standard...
@majinghe, This is the change I was proposing earlier. Let me know what you think, and I can also update the README.md accordingly.
Hello @jurim76, thank you for your feedback. Could you please be more specific about your comments?
@jurim76, I've added support for both existing pull secrets and auto-generated ones from credentials, as discussed with @majinghe before. Need feedback from a contributor before any other action.
@jurim76, I agree that most Helm charts follow what you mentioned here. However, @majinghe's new approach for creating imagePullSecrets from credentials addresses the issue I raised in #1123, which is...