Cyril Tovena

Results 110 comments of Cyril Tovena

> Whilst a string.Builder can reduce allocations it may actually be better to keep a small buffer or the builder around in order to reduce allocs further. Yes that sounds...

I also do have a concern for etcd, it could potentially be a lot depending on the design. A Kubernetes event each time a player join ?

FrostDB uses a lot of OpenFile for reading row in memory. I think https://github.com/segmentio/parquet-go/pull/255 will help. I went for the pool per schema/dynamic columns as I think over allocating is...

That's what I actually do.

I refer to this one yes. but it's hidden down below into mimir.

It's more items data sent back to users of the library take a profile of the store gateway, it should be one of the most alloc. The author left a...

This one https://github.com/bradfitz/gomemcache/blob/a41fca850d0b6f392931a78cbae438803ea0b886/memcache/memcache.go#L509 Would be awesome to have a way to reuse them when the item is not needed anymore.

That's the spirit I think the hardest part is the usage. If you go for it Prometheus code base as a pool that is bucketed and should work nicely. May...

The benchmark is wrong they both make the slice. I think you should: - use a https://github.com/prometheus/prometheus/blob/main/pkg/pool/pool.go - allocate inside the Get and not outside. ( The one allocating should...

It's better but I don't think you need a bytes.Buffer you can use the slice and re-sliced it to length required.