cypress-docker-images icon indicating copy to clipboard operation
cypress-docker-images copied to clipboard

feat(base): generate new image with version 18.6.0

Open ivangabriele opened this issue 3 years ago • 4 comments
trafficstars

Splitting #712

ivangabriele avatar Jul 26 '22 13:07 ivangabriele

@admah Don't hesitate to tell me if anything is missing. I took the liberty to clean some docs.

ivangabriele avatar Jul 28 '22 07:07 ivangabriele

@ivangabriele it looks like there are some failures in testing unrelated to this PR, but that we will need to get sorted out before this is merged. Just wanted to give you a heads up.

admah avatar Jul 29 '22 16:07 admah

@admah Thanks for the heads up ^^. I'll rebase this branch once master is ready.

ivangabriele avatar Aug 01 '22 06:08 ivangabriele

@ivangabriele master is good to go. Update this branch and I'll take a look. Thanks!

admah avatar Aug 04 '22 21:08 admah

@admah Sorry for the late update! I just rebased ;). I'm not sure why the CI don't run the new generated job, I guess it's because of Github branch protection rules ^^.

ivangabriele avatar Aug 21 '22 18:08 ivangabriele

I made a new PR since it's easier than resolving conflicts: https://github.com/cypress-io/cypress-docker-images/pull/738

lmiller1990 avatar Sep 01 '22 06:09 lmiller1990

Closing this now that #738 has been merged.

admah avatar Sep 01 '22 06:09 admah