cypress-docker-images icon indicating copy to clipboard operation
cypress-docker-images copied to clipboard

Update generate-config.js

Open wildone opened this issue 3 years ago • 3 comments

Current images have lots of layers, we can squash most of the layers to allow quick installation. This will also reduce the image size.

This is an intermediate step before rewriting docker files to use intermediate build layers, which would be more of a long term solution and a docker best practice. https://docs.docker.com/engine/reference/builder/#from

Squash docs are here https://docs.docker.com/engine/reference/commandline/image_build/

wildone avatar Feb 21 '22 11:02 wildone

@wildone could you describe more in detail what the purpose of this change would be? Maybe attach a link to the Docker docs on it?

admah avatar Feb 21 '22 15:02 admah

@wildone could you describe more in detail what the purpose of this change would be? Maybe attach a link to the Docker docs on it?

Is that ok?

wildone avatar Feb 21 '22 23:02 wildone

@wildone thanks for documenting this. We'll take a look and test it out.

admah avatar Feb 23 '22 01:02 admah

@wildone , thanks for the pr! However we've recently reworked how we generate dockerfiles which makes this pr no longer applicable.

mjhenkes avatar Jan 18 '23 14:01 mjhenkes