Wang Xinyong

Results 19 comments of Wang Xinyong

sorry, I am too busy these days, I will review this heavy PR carefully later.

@xpol ``` 1. split sync and async code in pc_tranc.c into different functions. 2. pc__trans_resp, pc__trans_sent and pc__trans_fire_event will not queue items, the pending arg has removed. ``` I think...

#66 is merged, awesome

@losingle , 1. 关于对 #23 的修复,需要您改一下,然后再重新推一下就好了 2. 关于android的编译,我手边没有安卓开发环境,只要你确认没问题,就可以apply 谢谢!

@losingle 还有再去看一下 #23 的评论, 对queue的访问需要加锁,这个别忘了, #23 里面实际上已经有一个可用patch了,把那个整理一下就好了

@xpol I'm afraid `PC_PRE_ALLOC_SET_IDLE` inside `pc__handle_event` should be protected by `event_mutex` as we release the mutex before entering `pc__handle_event` Thanks!

we should ensure `pc_client_cleanup()` never be called in polling callbacks, so do async callbacks

Any contributions on lua binding are welcome, as we have the plan for it. Do you have interest on it?

关于这个问题,请参考讨论 [http://nodejs.netease.com/topic/543aa8bccb93b0031f4f5f23](http://nodejs.netease.com/topic/543aa8bccb93b0031f4f5f23)

@Jennal @oliverzy 这个bug,目前不打算修了,以后可能会修改协议修复