Herbie Ong

Results 22 comments of Herbie Ong

encoding/protojson: marshaled `element in array/map` and `[]byte(nil)` to zero value instead with `null`

> Another case: > > ``` > &testv1.CaseValue{ > Vs: []*structpb.Value{ > structpb.NewNullValue(), > nil, > }, > } > ``` > > This results in an error `google.protobuf.Value: none...

json format: how should google.protobuf.Any with google.protobuf.Empty payload be rendered?

I'm starting to look into Go's v2 implementation of jsonpb. It would be nice to get clarifications on this. Thanks!

json format: how should google.protobuf.Any with google.protobuf.Empty payload be rendered?

Thanks for the clarification. Can someone update the doc in https://developers.google.com/protocol-buffers/docs/reference/google.protobuf#google.protobuf.Empty to make it clearer? I'd suggest -- "The custom JSON representation for Empty is empty JSON object {}." The...

encoding/protojson: DiscardUnknown doesn't work for unknown enum strings

Sorry for the late response. I just checked using libprotoc 3.13.0, and with JsonParseOptions.ignore_unknown_fields = true, C++ lib does ignore unknown enum **string** value. For a singular field, it "ignores"...

encoding/protojson: DiscardUnknown doesn't work for unknown enum strings

The Language Guide ([proto2](https://developers.google.com/protocol-buffers/docs/proto) and [proto3](https://developers.google.com/protocol-buffers/docs/proto)) have no mention on how to handle this for JSON. The [section on JSON options](https://developers.google.com/protocol-buffers/docs/proto3#json) simply mention about **Ignore unknown fields**: Proto3 JSON parser...

encoding/protojson: DiscardUnknown doesn't work for unknown enum strings

Yes, getting approval from the main protobuf project is always the right approach for getting consistency across the proto specification and across different languages.

encoding/protojson: DiscardUnknown doesn't work for unknown enum strings

Hi @noahdietz, Thanks for engaging the Protobuf team on this. I'd appreciate it if your team or the Protobuf team can update the [Protobuf Language Guide](https://developers.google.com/protocol-buffers/docs/proto) with regards to what...

encoding/protojson: DiscardUnknown doesn't work for unknown enum strings

@noahdietz >> I'd appreciate it if your team or the Protobuf team can update the Protobuf Language Guide > > Definitely! I'll pass that along :) Sorry, I should be...

encoding/protojson: DiscardUnknown doesn't work for unknown enum strings

It would be a lot better if the discussion is being done externally, preferably on the [Protobuf issue tracker](https://github.com/protocolbuffers/protobuf/issues). It'll at least allow for contributors and users of different implementations...

protoc-gen-go: generate MarshalJSON/UnmarshalJSON methods for messages

@morphar Curious, how did you set the JSON struct tag value of "-" on a generated type field? If this is for a dynamic message type, you can implement JSONPBMarshaler/JSONPBUnmarshaler....