Long non-ASCII robot name crashes the controller.

[amrytov]

Describe the Bug

See the subj.

Steps to Reproduce

1. Create an empty world
2. Put a Robot node in it. No child nodes are needed.
3. Leave the <generic> controller as is.
4. Name the robot with any long non-ascii name ("ЭтоДлинноеИмяДляРобота")
5. Run the simulation

** What happens:

I've just seen each of the following, in different combinations:

• the controller crashes (both mine and the <generic>, but this is not very reproducable, so no screenshot)
• errors starting the controller (see the screenshot)
• errors resetting the simulation (see the screenshot)

Expected behavior

Either accept the name as valid and then work correctly, or report that the name is too long or contains illegal characters and not accept it.

Suggested possible solution(s):

(a) Check validity of the string assigned to the 'name' field (don't allow such names) (b) don't use robot name directly to create pipe names or whatever, instead create some fixed-length harmless hash string from them, so that any strings can be safely used.

Screenshots

System

• Operating System: Windows 10