robot-designer icon indicating copy to clipboard operation
robot-designer copied to clipboard

Overall Modules and Classes Design

Open fabienrohrer opened this issue 6 years ago • 4 comments

Here is a new iteration on the module and class design: https://github.com/omichel/robot-designer/wiki/Design

Since the last version and according the Olivier:

  • The view3D and the partView have been separated into 2 modules.
  • Classes and modules are listed in a more exhaustive way.
  • A top module has been introduced.

Moreover:

  • I renamed "View3D" to "RobotView"
  • I dropped the UIControl classes which could be implicitly added the main class of each module (RobotView, etc.)
  • I added a PartBrowser module.
  • I didn't show all the interactions with the data blocks (DOM, ThreeJS), because they are implicit in most of the cases.

This document needs to be validated and improved with the implementation.

fabienrohrer avatar Oct 11 '18 09:10 fabienrohrer

Thank you. It looks much better to me like that. Two minor comments:

  1. It seems the PartMediator class is duplicated.
  2. PartView should link to Part Controller, not RobotController.

omichel avatar Oct 11 '18 09:10 omichel

  1. It seems the PartMediator class is duplicated.

This is done on purpose. For example, when a color is changed on a part, it should be dealt in the 3D view and in the part view, so both of them should listen the part model,

  1. PartView should link to Part Controller, not RobotController.

OK.

fabienrohrer avatar Oct 11 '18 10:10 fabienrohrer

So, do we have two "PartMediator" classes or only one? If only one, in which module is it stored?

omichel avatar Oct 11 '18 10:10 omichel

I planned 2 classes. There is a name clash to solve.

fabienrohrer avatar Oct 11 '18 10:10 fabienrohrer