Chris Yang

Results 81 comments of Chris Yang

Looks like this is a video_player issue. Removing the engine label and labelled with package to route the issue to the package team. CC @hellohuanlin

I think this is the same as https://github.com/flutter/flutter/issues/125620 and should be fixed by https://github.com/flutter/engine/commit/727b4413fe6fd12f55dd89c468cba80a86f34ae7 Can you try on master to see if it is fixed?

Lower the priority of this one since the majority of the failures mentioned in this issue is tracked in https://github.com/flutter/flutter/issues/120808

I don't think it is a rendering issue. It looks like the bottom inset is not animating with the same animation curve that the keyboard uses.

We might need to adjust the `preferredFrameRateRange` of the CADisplayLink on the rendering time of the last few frames. This is something we have discussed in the past. cc @iskakaushik...

In addition to what @0xZOne has looked: I looked at the hitch profiler almost all the hitches during the PlatformView scrolling are type: `commit to render latency: delay frame swap`....

> It seems unreasonable that the -[CAMetalLayer nextDrawable] is so time-consuming. nextDrawable can wait for up to 1 second according to https://developer.apple.com/documentation/quartzcore/cametallayer/2887086-allowsnextdrawabletimeout?language=objc

Just found out that the maskView is construction is expensive. https://github.com/flutter/engine/blob/main/shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm#L435-L439. Removing this line helps with the performance a lot. I'm going on a vacation and will continue looking after...

I removed the nextDrawable call and only let the app show PlatformView, the issue can still be seen. Example engine code without `nextDrawable`: https://github.com/flutter/engine/pull/38751

> If it comes to the fact that as soon as a PlatformView is displayed the frame rate is limited, I would prefer an opt-in. For example, if a user...