Chris Yang
Chris Yang
Looks like there are some tests failures on Mac Unopt for `-[FlutterPlatformViewsTest testEditBackdropFilters]` The Linux test failure is unrelated, you can resolve it by rebasing main.
The scenario test is failing due to blur is implemented in this PR. However, the scenario app uses a none-zero origin for the PlatformView, making the blur not working probably....
Need to merge https://github.com/flutter/engine/pull/34355 before landing this.
> @cyanglaz Trying to understand the status here. Per your last comment, this patch depends on #34355 which landed but had to be reverted due to [flutter/flutter#109831](https://github.com/flutter/flutter/issues/109831) and now the...
Wait until https://github.com/flutter/flutter/pull/110688 is landed before landing this.
Having some issue with local build and im trying to fix it. Meanwhile, im pushing the `#include "unicode/uchar.h"` to wait for ci
```Test Case '-[FlutterTextInputPluginTest testCachedComposedCharacterClearedAtKeyboardInteraction]' started. 2022-10-11 16:54:34.354889-0700 IosUnitTests[39515:758479] Failed to find assets path for "Frameworks/App.framework/flutter_assets" 2022-10-11 16:54:34.378126-0700 IosUnitTests[39515:760334] [VERBOSE-2:engine.cc(200)] Engine run configuration was invalid. 2022-10-11 16:54:34.379990-0700 IosUnitTests[39515:760334] [VERBOSE-2:shell.cc(604)] Could not...
Closing in favor of https://github.com/flutter/engine/pull/36807
Looks like the bug wasn't what I thought in https://github.com/flutter/flutter/issues/109845#issuecomment-1222742951. @LongCatIsLooong @justinmc Are you the right people to review this? @RichardFevrier, tests need to be added in order for this...
> I can try that @cyanglaz on my iPad but is there not a Unit test to check it automatically? We do have unit-tests cover it but not integration test....