Carl Pearson
Carl Pearson
Opened https://github.com/kokkos/kokkos-core-wiki/pull/580 to take care of a small part of this.
Am I reading this right that "approach 1", the build with passing tests has cuSPARSE, UVM, and CUDA RDC disabled, but is otherwise the same as the failing build? Or...
The bugprone-reserved-identifiers check seems to catch reserved patterns reliably (this is my first time using clang-tidy). It may make sense to add it as an automatic check.
It does catch them, this PR just does one kind of change at a time 😄
We're not actually running clang-tidy in CI yet, let me get it to pass cleanly when run manually and then I can make a PR to add a CI check.
Oh `KOKKOS_ATTRIBUTE_NODISCARD` is deprecated.
I like this one more than #8367 because in #8367 the definition of `sum_views` has a `RangePolicy` in it which obfuscates the compatibility with `TeamPolicy`. This one at least there...
Interestingly those other ones are either not `KOKKOS_` or they have `IMPL` in the name, in which case I feel happy to just rename them. This is the one special...
I'm perfectly happy to have this be deprecated 5 if it makes things easier for users.
I don't think supporting LO > int is conceptually crazy since the amount of memory on each node has been steadily growing, but it may take us a while to...