`KOKKOS_CUSPARSE_SAFE_CALL` has `KOKKOS_` prefix

Open cwpearson opened this issue 1 year ago • 2 comments

https://github.com/kokkos/kokkos-kernels/blob/c7df61d536c74effb3e4466b011f67f24e85f314/sparse/src/KokkosSparse_Utils_cusparse.hpp#L67-L69

Let's be good ecosystem partners and prefix this with KOKKOSSPARSE_ instead.

I personally don't think this should be part of our interface. Is this intentional? If so, let's use KOKKOSSPARSE_CUSPARSE_SAFE_CALL, otherwise let's deprecate it and use KOKKOSSPARSE_IMPL_CUSPPARSE_SAFE_CALL.

Oct 10 '24 15:10 cwpearson

I think the last option makes sense: KOKKOSSPARSE_IMPL_CUSPARSE_SAFE_CALL, eventually we should review what we are doing for other libraries like rocSPARSE, rocBLAS, etc...

Oct 10 '24 15:10 lucbv

Interestingly those other ones are either not KOKKOS_ or they have IMPL in the name, in which case I feel happy to just rename them. This is the one special case.

Oct 10 '24 15:10 cwpearson