Christopher Wecht

Results 17 comments of Christopher Wecht
trafficstars

@yli-cpr could you elaborate on the concrete problem you are facing? Do you need an error message for debugging/logging purposes or do you want your nodes to be able to...

Well, it kind of does, the message is read here: https://github.com/ros/ros_comm/blob/29053c4832229efa7160fb944c05e3bc82e11540/clients/roscpp/src/libros/service_server_link.cpp#L246 and printed here: https://github.com/ros/ros_comm/blob/29053c4832229efa7160fb944c05e3bc82e11540/clients/roscpp/src/libros/service_server_link.cpp#L378

@thebhatman could you provide a minimal (not) working example?

This PR is basically a direct follow up to #120. At the time I only checked whether rmw_connextmicro build successfully. Later I discuvered this issue with Connext Micro exporting symbols...

@asorbini I found neither for ConnextDDS Micro 3.0.3.28 nor for 2.4.13.4 any definition for DDS_TIME_INVALID.

What about deprecating these constructors? This would make it easier to spot the places, where they are used without breaking any code all of a sudden.

You can define SimpleActionClient and SimpleActionServer as members of classes. You just need to initialize them in the member initializer list of the constructor. A popular alternative is to put...

Did anyone ever test this PR with irobot's events executors? https://github.com/irobot-ros/events-executor If I run their tests with rmw_connextdds enabled and these changes here applied to the rmw_connextdds humble branch, I...

#109 fixes the issue with the events executors.

What's the status of this PR? Given that https://github.com/ros2/rclcpp/pull/2155 is merged now, it would be really greate to have this PR "officially" approved and merged in order to use rclcpp...