Hans Wang

Results 6 comments of Hans Wang

Hi everyone, Was wondering if anyone here know if there is a some work-around to mitigate this issue? Our project has requirements from OpenZeppeplin but that dependencies are in 3.0...

Was wondering if anyone got into this errors ? After some trials, it seems the legacy components won't have this issue 🤔

The scenario will fail as we encountered back in Arbitrum native usdc deploy. Since this is deploying another comet on the chain with existing governor contract, without proper setFactory, setConfigurator...

> Looks great! Could you also add unit tests for `supply base`, `supply collateral`, and `buy collateral`? I notice there is no scenarios for `buy collateral`, so would be good...

Synced with ⛑️ offline. For the re-entrancy issue that Comet is not immune to the tokens that's got exploited. (i.e. EvilToken.sol) We decided to not adding additional layer to prevent...

No problem. Happy to help :) Thanks @juanmardefago . I have also quick-fixed the merge conflict, this PR is good to merge anytime.