Cyril VINH-TUNG

Results 105 comments of Cyril VINH-TUNG

@luisDIXMIT can you apply changes of v16 please https://github.com/OCA/connector-telephony/pull/319 And maybe rebase from v16... it would be easier to review

> What is the status of this? What are the next steps to get it merged? We need 2 approvals

> Hello @etobella , is it functional now? We use it in production for weeks, I guess it's ok

> @cvinh thanks a lot for the PR. Check Travis that is failing due to https://app.travis-ci.com/github/OCA/social/jobs/561474317#L1690 Also please squash the last commits, according to https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-14.0 you should only have: >...

> Maybe this one is better --> https://github.com/OCA/social/tree/12.0/mail_show_follower . Did you have a look? @HaraldPanten Thanks for pointing that one

@rafaelbn @tafaRU IMHO mail_show_followers is great but it will not warn email recipients that if they reply to the catchall address, all the followers (internal or external) will ne notified...

> this is about inform to the user (the client of the client of the client, not our client) that is she/he answer to an email that is generic (like...

> @cvinh take care what @sbidoul said here [#855 (comment)](https://github.com/OCA/social/pull/855#issuecomment-1072378496) . The original module is from v8 https://github.com/OCA/social/tree/8.0/mail_footer_notified_partners > > @sbidoul in some moment in v12 we had two modules...

@rafaelbn thank you for reporting this. We adopted mail_show_followers and did not see the bug you pointed out. We are going to confirm and maybe go back to mail_notified_partner

@rafaelbn can you help fixing tests please ? I am not good with them Also I reopened the changing name PR https://github.com/OCA/social/pull/857 (I was renaming it in mail_body_notified_partner is it...