pos icon indicating copy to clipboard operation
pos copied to clipboard

[17.0][MIG] pos_product_template: Migration to 17.0

Open etobella opened this issue 10 months ago • 5 comments

Refactorized using new OWL logic

/ocabot migration pos_product_template

@cvinh @luisDIXMIT

etobella avatar Apr 20 '24 19:04 etobella

/ocabot migration pos_product_template

Please check CI

pedrobaeza avatar Apr 20 '24 22:04 pedrobaeza

@pedrobaeza error is unrelated. All tests are failing on 17.0. Fixed here https://github.com/OCA/pos/pull/1179

etobella avatar Apr 21 '24 17:04 etobella

You can rebase now.

pedrobaeza avatar Apr 21 '24 19:04 pedrobaeza

Tested on Runboat. There are two functionalities in the README file that may be failing. On one hand, the README file explains that if a product has variants, the number of variants should be shown instead of the price. However, nothing is displayed.

image

On the other hand, the variant attributes should function as filters, as explained in the README file, but it appears not to be working.

image

Could you please check this, @etobella? Maybe I'm interpreting the README file incorrectly. Thanks.

image

luisDIXMIT avatar Apr 22 '24 06:04 luisDIXMIT

@luisDIXMIT Reviewed, thanks!

etobella avatar May 20 '24 12:05 etobella

Hello @etobella , is it functional now?

SapphireHotS avatar Sep 09 '24 06:09 SapphireHotS

Hello @etobella , is it functional now?

We use it in production for weeks, I guess it's ok

cvinh avatar Sep 09 '24 06:09 cvinh

/ocabot merge nobump

pedrobaeza avatar Sep 09 '24 12:09 pedrobaeza

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1178-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot avatar Sep 09 '24 12:09 OCA-git-bot

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1178-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

OCA-git-bot avatar Sep 09 '24 12:09 OCA-git-bot

@etobella can you please rebase to check if the problem is transient?

pedrobaeza avatar Sep 09 '24 12:09 pedrobaeza

Seems a change on Odoo

etobella avatar Sep 09 '24 12:09 etobella

:facepalm:

pedrobaeza avatar Sep 09 '24 13:09 pedrobaeza

It seems that product_lot_barcode and product_lot_selection are colliding for some reason. I will investigate

etobella avatar Sep 09 '24 21:09 etobella

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot avatar Sep 09 '24 21:09 OCA-git-bot

It seems that product_lot_barcode and product_lot_selection are colliding for some reason. I will investigate

Could this be https://github.com/OCA/pos/pull/1232 the cause?

FernandoRomera avatar Sep 10 '24 04:09 FernandoRomera

/ocabot merge nobump

ivantodorovich avatar Sep 18 '24 11:09 ivantodorovich

Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1178-by-ivantodorovich-bump-nobump, awaiting test results.

OCA-git-bot avatar Sep 18 '24 11:09 OCA-git-bot

Congratulations, your PR was merged at 85ce73efcb888ed7e535eb3edcc41431f35068a8. Thanks a lot for contributing to OCA. ❤️

OCA-git-bot avatar Sep 18 '24 11:09 OCA-git-bot