pos
pos copied to clipboard
[17.0][MIG] pos_product_template: Migration to 17.0
Refactorized using new OWL logic
/ocabot migration pos_product_template
@cvinh @luisDIXMIT
/ocabot migration pos_product_template
Please check CI
@pedrobaeza error is unrelated. All tests are failing on 17.0. Fixed here https://github.com/OCA/pos/pull/1179
You can rebase now.
Tested on Runboat. There are two functionalities in the README file that may be failing. On one hand, the README file explains that if a product has variants, the number of variants should be shown instead of the price. However, nothing is displayed.
On the other hand, the variant attributes should function as filters, as explained in the README file, but it appears not to be working.
Could you please check this, @etobella? Maybe I'm interpreting the README file incorrectly. Thanks.
@luisDIXMIT Reviewed, thanks!
Hello @etobella , is it functional now?
Hello @etobella , is it functional now?
We use it in production for weeks, I guess it's ok
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1178-by-pedrobaeza-bump-nobump, awaiting test results.
@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 17.0-ocabot-merge-pr-1178-by-pedrobaeza-bump-nobump.
After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.
@etobella can you please rebase to check if the problem is transient?
Seems a change on Odoo
:facepalm:
It seems that product_lot_barcode and product_lot_selection are colliding for some reason. I will investigate
This PR has the approved
label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖
It seems that product_lot_barcode and product_lot_selection are colliding for some reason. I will investigate
Could this be https://github.com/OCA/pos/pull/1232 the cause?
/ocabot merge nobump
Hey, thanks for contributing! Proceeding to merge this for you. Prepared branch 17.0-ocabot-merge-pr-1178-by-ivantodorovich-bump-nobump, awaiting test results.
Congratulations, your PR was merged at 85ce73efcb888ed7e535eb3edcc41431f35068a8. Thanks a lot for contributing to OCA. ❤️