pixel-perfect-sfm icon indicating copy to clipboard operation
pixel-perfect-sfm copied to clipboard

Published 20 hours ago • verified publisher icon cvg

Fixed to allow compilation on macOS M1

Open ducha-aiki opened this issue 3 years ago • 6 comments

Full story described here https://github.com/cvg/pixel-perfect-sfm/issues/47

ducha-aiki avatar Apr 13 '22 14:04 ducha-aiki

We use this pull request in conda-forge (see #93) - is there a reason why it is not being merged?

Tobias-Fischer avatar Jun 29 '23 23:06 Tobias-Fischer

I think the changes around FindPythonPyEnv are not needed, but the other ones are relatively trivial and are required for clang.

Tobias-Fischer avatar Jun 29 '23 23:06 Tobias-Fischer

Thanks @ducha-aiki for the PR. We'll merge only if the changes are minimally required for the feature - it looks like right now there they're fixing multiples issues at once. Are these changes related to M1 architectures or to clang? I don't have an M1 computer at hand but I can run clang.

sarlinpe avatar Jul 10 '23 09:07 sarlinpe

Well, for me, the "feature" is "works on my M1 machine with minimal changes". I don't have any Intel clang, unfortunately. Let me check if that works w/o FindPythonPyEnv and with auto-AVX

ducha-aiki avatar Jul 10 '23 10:07 ducha-aiki

@Skydes I have updated PR

ducha-aiki avatar Jul 10 '23 10:07 ducha-aiki

LGTM :)

Tobias-Fischer avatar Jul 10 '23 19:07 Tobias-Fischer