Josh Stone

Results 817 comments of Josh Stone

See #333 - it doesn't have to be a breaking change, but I'd rather wait for them to be stable.

There are several multi-maps on crates.io, the most downloaded being https://crates.io/crates/multimap. Maybe it would be better to contribute there? They are currently wrapping `std` with `HashMap`, but it would be...

> Yeap, that was the idea. Having whole `Vec` when you may only have like 1 or 2 of them seems wasteful. You could use `SmallVec` to avoid the heap...

> I think that it would be useful to _allow_ tables with duplicate keys in `hashbrown`. [...] Right now, there is technically no supported way of even using hashbrown to...

The only relevant doc I found is at the top of `HashTable`: > Due to its low-level nature, this type provides fewer guarantees than [HashMap](https://docs.rs/hashbrown/latest/hashbrown/hash_map/struct.HashMap.html) and [HashSet](https://docs.rs/hashbrown/latest/hashbrown/hash_set/struct.HashSet.html). Specifically, the API...

Is it reproducible with the current Rust 1.81.0 toolchain? That will also be using the latest `hashbrown v0.14.5`.

I don't know what in particular may have fixed it. If you share your code and reproduction steps, I may be able to investigate, but generally speaking only the current...

> I use `if hashmap.contains_key(k)` before hashmap.get to avoid the segfault issue, That sounds like it may be a miscompilation by `rustc`/`LLVM`. Is there a reason you can't use the...

`cargo-bisect-rustc` should be able to use nightly builds to get you most of the way. If it is a codegen problem, I suspect you'll find a big change like "upgrade...

We can only add this if there's a generic implementation. Have you attempted that?