Josh Stone

Results 817 comments of Josh Stone

I think would prefer to have Cargo pass through the `--target` option in the environment, either directly in `TARGET` or in a new variable if that "short name" behavior can't...

I'm considering that override hack, but one thing is that I think it should only take effect for `TARGET != HOST`, because an external environment can't make that distinction while...

> Doesn't cargo independently monitor variables (actually cfg- values) that are significant for compilation? Env vars produced from the config, and when you change the config (all is the config!),...

This proposal doesn't rely on unique features of `IndexMap`/`IndexSet`, which makes it a case where I would prefer to see an API standardized in `HashMap`/`HashSet` first, so we can implement...

> Hehe, I was hoping to set a precedent with this crate, and then do a PR into Rust lang :) Sorry, kind of a chicken-and-egg situation there, since we...

For `Copy`-able key-values (less general than `ToOwned`), you could change your example to: ```rust let mut hm = std::collections::HashMap::::with_capacity(env.len()); hm.extend(env.iter()); // using `Extend` ``` (edit: I wrote `Clone`-able at first,...

Given the FCP-close on rust-lang/rust#56167, I don't think any advanced raw-entry translation will be possible, and for the rest there's `FromIterator`.

Yes, but I'll want to match the eventual API of the standard library `HashSet`, rust-lang/rust#60896. I don't mind having a draft PR waiting for that, if you're so inclined, but...

As I mentioned before, the standard library is the blocker to make sure we match a stable API. I agree the implementation is not hard, and if you want you...