Josh Stone

Results 817 comments of Josh Stone

> There is a thread-local structure (`Resamples`) which holds a borrow of the shared vector `c`. I couldn't figure out a way to do that in Rayon without creating a...

I suppose this may be an pseudo-internal API-break between `genawaiter` and `genawaiter-proc-macro`.

@rcls I think that's not calling *your* `FnOnce`, but rather the blanket `impl FnOnce for &mut F` that uses `call_mut`, so you'll have infinite recursion.

`CheckAtomic.cmake` tries 64-bit atomics with and without `libatomic`. I see it will add to `CMAKE_REQUIRED_LIBRARIES` if needed, but then `lld` and `lldb` also add to their respective `*_SYSTEM_LIBS`. Does LLVM...

@bors r+ rollup=never

The `CUSTOM_MINGW` toolchain is only 6.3, but for now we can allow it. @bors r+ rollup=never

Nice! We'll want to follow up on all builders that `--set llvm.allow-old-toolchain`, but those changes should stand alone, whether you land that before or after this PR. @nikic are you...

Alright, I pushed that LLD fix as well. @bors r+

Once they're called `cast_`, I wonder if we should also add a type parameter like the existing `cast` method, so you don't have to double up `.cast().cast_const()` etc. (However, they...

This should be good as far as capturing noteworthy items, but suggestions are welcome in case I missed anything, especially for interesting "internal changes". I still need to tweak a...