Don C. Weber
Don C. Weber
The use of spaces in folder and file names is a horrible practice. It makes importing data into other tools and scripts very difficult. Example: ``` cutaway 2022-09-08 06:32:15 >...
**What would you like to add or change?**: Recommend updating the Docker Hub directions to include information about running Docker on OSX and using it for one-time analysis of a...
### Describe the problem The EventData in the Bits-Client log contains a field named 'Id' (note lowercase d). When processing the log's message a new key is created for the...
I noticed some hard coded developer directories in some of the files, including configuration files. These should probably be updated to improve building and also prevent information leakage. ``` IOA...
I followed the INSTALL instructions to configure and make the project. Running `configure --local` fails initially because the 'build' directory is not present. Adding the 'build' directory does allow the...
It would be interesting to see some mitigation recommendations. I believe this would be helpful for organizations that are trying to address the issues that you have addressed with this...
A few recommendations that would have saved me some time. Please add a comment about the MISP admin account password (MISP_ADMIN_PASSPHRASE) requirements. If the password does not match these requirements...
The CLICKs appears to have [memory types](https://accautomation.ca/click-plc-numbering-system-and-addressing/) that are not supported here. I've exported the addresses which have the memory types and Modbus address in case you (or someone else)...