Liam Miller-Cushon

re: `if (getSomeSet().isEmpty()) { ... }`, that change that added `java.util.Date` also added (or re-added?) handling to report findings in invocations of depreated types. When I moved the `Date` stuff...

This isn't a regression in that check, it just wasn't enabled by default before 2.4.0: https://github.com/google/error-prone/commit/6fe51560740276302ccd0b117640b8e24666c6ad The purpose of the check is to warn on uses of non-standard tags to...

> Switching to Lombok v2.18.24 fixes this particular issue for us. Thanks for trying that. > Our build then fails on a different issue, but maybe you'll get lucky and...

Both of those checks have heuristics with lists of annotations they recognize as meaning the variable or method isn't actually unused: * https://github.com/google/error-prone/blob/master/core/src/main/java/com/google/errorprone/bugpatterns/UnusedMethod.java#L93 * https://github.com/google/error-prone/blob/master/core/src/main/java/com/google/errorprone/bugpatterns/UnusedVariable.java#L129 I'm happy to take PRs...

Note that there are two different `--add-exports=` flags: the runtime JVM flag, and the compile-time javac flag. The installation docs describe the runtime JVM, because that's what you need to...

I don't know very much about OSGi. Is this a regression from earlier versions of Error Prone? Do you know what changed in guice 5.1.0 that worked previously?

Sorry, I don't think it will, f8185d142a8a2e389ba1a37b92833809de4e3f12 should be a no-op for check behaviour, it's just moving the computation of the APIs to check to happen statically instead of every...

Also I think that banning everything under `javax.lang` makes sense, although I need to do some more testing to confirm that wouldn't cause any issues with our existing uses of...

The underlying exception I'm seeing is: ``` Caused by: java.lang.IllegalArgumentException: ./caffeine/caffeine/src/main/java/com/github/benmanes/caffeine/cache/LocalAsyncCache.java at jdk.compiler/com.sun.tools.javac.file.JavacFileManager.asPath(JavacFileManager.java:1189) at jdk.compiler/com.sun.tools.javac.file.JavacFileManager.contains(JavacFileManager.java:1115) at [email protected]/javax.tools.ForwardingJavaFileManager.contains(ForwardingJavaFileManager.java:212) at jdk.compiler/com.sun.tools.javac.api.ClientCodeWrapper$WrappedJavaFileManager.contains(ClientCodeWrapper.java:331) at jdk.compiler/com.sun.tools.javac.main.DelegatingJavaFileManager.contains(DelegatingJavaFileManager.java:173) at jdk.compiler/com.sun.tools.javac.main.DelegatingJavaFileManager.contains(DelegatingJavaFileManager.java:173) at jdk.compiler/com.sun.tools.javac.comp.Modules.checkSourceLocation(Modules.java:534) at jdk.compiler/com.sun.tools.javac.comp.Modules.setCompilationUnitModules(Modules.java:524) at jdk.compiler/com.sun.tools.javac.comp.Modules.enter(Modules.java:267) at...

I'm suspicious that either: * this will return file objects that don't match the installed file manager, if a custom filemanager has been installed: https://github.com/google/error-prone/blob/726d179974f769e05dcdd3e97f7c384e5649d26d/check_api/src/main/java/com/google/errorprone/fixes/SuggestedFixes.java#L1412 * these `SimpleJavaFileObject`s don't match...