Liam Miller-Cushon

Results 183 comments of Liam Miller-Cushon

https://github.com/google/google-java-format/issues/434

@romani there's some documentation about this here: https://github.com/google/google-java-format?tab=readme-ov-file#as-a-library, the `--add-exports=` flags are required when using google-java-format as a library

> `17-ea (Azul Systems, Inc. 17-ea+12)` I recommend using a released version of JDK 17 (or newer) instead of a JDK 17 early access build.

I'm working on getting this imported, but there are some details I need to work through internally and it might take another couple of weeks, sorry for the delay

`.jdeps` are produced by both `JavaBuilder` and turbine, and if turbine is disabled the build should use the `.jdeps` output from `JavaBuilder` instead. There are some other things that could...

The generated sources can be accessed via starlark * https://bazel.build/rules/lib/java_output#generated_source_jar * https://bazel.build/rules/lib/JavaInfo#source_jars

I think the best option for now is to write a small starlark rule or just use a genrule to either extract the `.jar` file to a directory, or rename...

Thanks for the report! That's already fixed in https://github.com/google/turbine/commit/468742ff49d1881bf4822bb9d0d820105b28dba8, I'm working on releasing a new version and updating Bazel's dependency on turbine.

Just adding support for `-XepPatchLocation:` doesn't seem ideal for Bazel, because as mentioned earlier `IN_PLACE` doesn't work with sandboxing, and setting a specific location doesn't make Bazel aware of those...

There's some related discussion about Bazel support for r8 in https://github.com/bazelbuild/bazel/pull/14966#issuecomment-1087797565