Leonhard Markert

Test "trivial_shell_nix" is flaky

4

This failed on master: https://travis-ci.org/target/lorri/jobs/604982303#L1682 ``` ---- tests::trivial_shell_nix stdout ---- thread 'tests::trivial_shell_nix' panicked at 'stdout: stderr:error: file 'nixpkgs' was not found in the Nix search path (add it using $NIX_PATH...

Test "trivial_watch_whole_directory" is flaky

2

This build failure occurred on a very innocent PR: https://github.com/target/lorri/pull/246 https://travis-ci.org/target/lorri/jobs/618236153#L958 ``` ---- watch::tests::trivial_watch_whole_directory stdout ---- thread 'watch::tests::trivial_watch_whole_directory' panicked at 'assertion failed: file_changed(&watcher, "foo")', src/watch.rs:288:9 note: Some details are omitted,...

Deserialization error: catch and provide suggestion

2

**Feature description** When a deserialization error of the protocol between the lorri daemon and a client occurs, lorri should output an error message suggesting that the versions of the daemon...

Caching on CI does not seem to work

5

Both the nix build and the cargo build appear to always build all dependencies from scratch, which leads to build times between 10 and 30 minutes. Example: https://travis-ci.org/target/lorri/builds/626109465

**Feature description** lorri should report shellHook failures. **Target users** People who use shellHooks. `nix-shell` swallows command failures in shellHooks, lorri does not. This is by design. However, lorri's logs don't...

Kubernetes OpenAPI spec compatibility

5

Fixes #128 and #82. Changes to make the Kubernetes fixture pass: - Ignore $ref declarations that are not strings - Allow primitive RPC return types - Update Kubernetes proto fixture...

Invalid protobuf files in fixtures/

3

`protoc` v3.7.1 throws errors when parsing `fixtures/accountv1-0.proto`: ```console $ protoc --version libprotoc 3.7.1 $ protoc -o/dev/null fixtures/accountv1-0.proto fixtures/accountv1-0.proto:342:14: "Permissions" is already defined in "accountinformationapis.AccountRequest.DataMessage". fixtures/accountv1-0.proto:646:14: "Permissions" is already defined in...

I think it makes sense to validate protobuf files used as fixtures in CI. This currently fails, demonstrating that some fixtures are currently not valid protobuf files. Related: https://github.com/nytimes/openapi2proto/issues/130

Failed to transpile Kubernetes swagger.json: "'$ref' key contains non-string element (map[string]interface {})"

1

Generating protos for https://github.com/kubernetes/kubernetes/blob/965137a992ed755474f17fa6377ee3555745addd/api/openapi-spec/swagger.json failed: ```console $ openapi2proto -spec kubernetes-swagger.json error: failed to transpile: failed to load OpenAPI spec: failed to resolve external references: failed to resolve object: failed to...

monad-bayes series Nix environment: update jupyterWith pin

3

This PR updates the pinned revision of `jupyterWith`. `jupyterWith` has macOS CI set up now. The revision this PR updates the pin to has passed macOS CI: https://github.com/tweag/jupyterWith/runs/733371600. Should fix...