openapi2proto icon indicating copy to clipboard operation
openapi2proto copied to clipboard

Published 20 hours ago • verified publisher icon nytimes

Kubernetes OpenAPI spec compatibility

Open curiousleo opened this issue 4 years ago • 5 comments

Fixes #128 and #82.

Changes to make the Kubernetes fixture pass:

  • Ignore $ref declarations that are not strings
  • Allow primitive RPC return types
  • Update Kubernetes proto fixture

Additional changes:

  • Allow primitive RPC request types, for symmetry with the return type change

I'm mostly feeling my way around at this point. I haven't tested the changes other than running go test.

curiousleo avatar Sep 16 '20 19:09 curiousleo

I don't really understand how kubernetes.proto was generated given that openapi2proto previously failed on kubernetes.json. So I'm not sure how valid it is to update kubernetes.proto here.

curiousleo avatar Sep 16 '20 19:09 curiousleo

Feedback welcome. Ping @jprobinson @lestrrat (you commented on #82 and seem to have some context on this).

curiousleo avatar Sep 16 '20 19:09 curiousleo

@jprobinson and @lestrrat seem to have moved on from NYT.

@JustinFullerNYT, do you have enough context on this project to provide feedback on this draft PR?

curiousleo avatar Sep 18 '20 15:09 curiousleo

@jprobinson and @lestrrat seem to have moved on from NYT.

@JustinFullerNYT, do you have enough context on this project to provide feedback on this draft PR?

I can take a look and recruit some others to look as well!

JustinFullerNYT avatar Sep 18 '20 15:09 JustinFullerNYT

@curiousleo / @JustinFullerNYT can we resurrect this?

tmc avatar Apr 18 '22 19:04 tmc