Joe Birr-Pixton

Results 158 comments of Joe Birr-Pixton

I think we would need to do #603 before this is possible, but I agree this would be a good clarity and efficiency improvement.

Note #998 achieves this another (much less graceful) way. This PR can remain for doing it in the more reasonable way: so please add a `git revert 5288fcf` to the...

Could you write precise reproduction steps for this? And preferably a pcap of it happening with a matching SSLKEYLOG?

Maybe worth noting that (AFAICT) nobody else follows this guidance either: - NSS: [SSL_ExportKeyingMaterial](https://github.com/servo/nss/blob/master/lib/ssl/ssl.h#L835) - BoringSSL: [SSL_export_keying_material](https://boringssl.googlesource.com/boringssl/+/27a0d086f7bbf7076270dbeee5e65552eb2eab3a/include/openssl/ssl.h#1300) - OpenSSL: [SSL_export_keying_material](https://www.openssl.org/docs/man1.1.1/man3/SSL_export_keying_material.html) - Microsoft CapiNG: [SslExportKeyingMaterial](https://docs.microsoft.com/en-us/windows/win32/seccng/sslexportkeyingmaterial) - golang crypto/tls: [ConnectionState.ExportKeyingMaterial](https://pkg.go.dev/crypto/tls#ConnectionState.ExportKeyingMaterial) Not that...

No plans at the minute. I know it's used for some VPNs, webrtc and some iot things. What is your use case?

> Would you see DTLS within the scope of this library Perhaps. I'm not sure some of the external APIs are really suitable, to the extent that it might make...

Looking good! 👍

DTLS/TLSMessage sounds ok, but beware that some performance relies on Message being moved by value into the processing functions: so the traits will need to cover these cases by exposing...

I don't have any wip branch for that yet. But I'll push one once I do and link it here.

How about separate `DatagramClientSession`/`DatagramServerSession` types? I'm assuming these types need some kind of extra methods for timed triggering of retransmits? On the question of `ClientSessionImpl`, could we inject implementations of...