Jens Reimann

Results 643 comments of Jens Reimann

> Shouldn't the /_trunk/ws url be relative to whatever that started the application? I would say that this endpoint is something specific to trunk (`serve`). Right now, `trunk serve` assuming...

So if you have something that works, I think it would be great to have a PR so that we can take a look at this. I am pretty sure...

I think this should be addressed by `0.19.x`, for which there's an RC now (`0.19.0-rc.1`). Maybe you can give it a try.

Not sure about the exact layout of your project, but there's a way to influence this lookup: https://trunkrs.dev/assets/#rust

I think this is a valuable tutorial. I am just not sure it needs to go into the main `trunk` repository. Unless I missed something that it does with trunk...

Well, for tailwind there is some support required from trunk. But bootstrap if pretty straight forward "vanilla".

Thanks for the PR! I will take a look in the next few days. Two more formal things: you will need to sign the Eclipse ECA and add the `Signed-off-by`...

Ok, it looks like there are still commits, signed off with an e-mail address, that has not signed the ECA. Maybe you can squash the commits and force-push the result...

I think you misspelled the footer entry `Signed-off-by` vs `Signed-off by` (missing dash). You should be able to see the validation results in the checks box of the PR. The...