Jens Reimann
Jens Reimann
I am currently trying to get this working. However, there is one issue with that PR. When any other crate pulls in `ring` too, this will automatically enable all sections...
> Interesting, are you saying that if you include this crate with `default-features = false, features = ["rustcrypto"]` that `#[cfg(feature = "ring")]`-gated code in this crate gets compiled if `ring`...
Well this would be even better. But I though it would also take much longer.
I think `build`, `clean`, `bench`, `fmt` sound like a good start. But you can also install custom commands yourself, which extend cargo. So I think it might be valuable to...
> But since this would arguably be an unneccessary breaking change, … Why would that be a breaking change? It only adds a new struct.
Thanks @aliemjay … that makes sense. I rebased the PR and made the suggested changes.
> If not how were you using `Condition`? Not at all. That is the point of this PR to enable this.
I moved this into an "extras" crate, so that it can be used in the meantime: https://crates.io/crates/actix-web-extras
I rebased the PR and added an entry in the changelog. The documentation was already there.
For me using `html![]` or `html!()` seems to work, but fails in a different way. It then detects the code as unreachable.