Jens Reimann

Results 686 comments of Jens Reimann

The main issue I have with this is that on most cases (at least for me so far :grin: ) was that I only need `bool` … and now I...

> I think the bigger issue is that more complicated components will start having more complicated callbacks - especially when adding the event itself as an argument to more callbacks...

> You could edit the config of the running deployment, I don't think it makes sense to add another knob here, we should just have a reasonable default. Unfortunately that's...

Right now evaluating the state looks a bit like this: ```rust #[function_component(EvalView)] pub fn eval_view(props: &EvalViewProps) -> Html { match &props.eval { UseAsyncState { loading: true, .. } => {...

I went ahead, trying to create an example of what I had in mind, something like: ```rust #[derive(PartialEq, Eq)] pub enum UseAsyncState { /// Operation has not been started yet...

> What are the advantages to having icons that aren't fixed width? Sometimes the better match into the flow of … text :) ![image](https://github.com/patternfly-yew/patternfly-yew/assets/202474/ab6f6dbf-ace2-48b7-8a86-a41d1cc7aac8) I had some major issues with...

I am wondering if, instead of `Icon`, we should just allow `Html` in such cases. `Icon` transforms into `Html` anyway.

Just because I again noticed it, GitHub also uses SVGs :grimacing: ![image](https://github.com/patternfly-yew/patternfly-yew/assets/202474/1c2b8880-8670-4b7b-96b7-007e9769fada)

But, there's a bunch of good icon sets out there. Font based or SVG based, I think we should be able to use all of them. For example: https://github.com/finnbear/yew_icons (not...

Right now, one can use `page_size` and `start_page`. However, there seems to be no simple way to use `limit` and `offset`. The idea is to provide a simple way to...