Jens Reimann comments

Results 686 comments of


                                            Jens Reimann

added support for basic file filtering when adding an explicit file

Sorry that this one has slipped my attention! I don't really understand the reason for this PR though. Couldn't you simply use the maven filtering and then scoop the files...

added support for basic file filtering when adding an explicit file

So why don't you just use https://maven.apache.org/plugins/maven-resources-plugin/copy-resources-mojo.html instead? I am not really fond of adding another dependency. Having a re-implementation of the filtering is also not really what I would...

Global switch for "exclude files outside source directories"

My suggestion would be to untick this flag by default and simply use the source set provided by the checkstyle plugin configuration from maven.

Uploading an artificat to a draft release doesn't work (not found)

Thanks for taking a look at this. We are using this pattern of (create draft, add assets, remove draft) in a bunch of cases. Sometimes with a more variable list...

micro:bit v2.20 fails to keep stable connection

Sure, I will try to. The full code is here: https://github.com/Eclipse-IoT/eclipsecon-2022-hackathon/tree/main/firmware * It is using defmt * The list of dependencies can be seen in the [Cargo.toml](https://github.com/Eclipse-IoT/eclipsecon-2022-hackathon/blob/main/firmware/Cargo.toml) file * >...

Create the correct PskIdentity type on query

Sorry for that.

"create or update" operation for device registry

but is that an API call? or a `drg` functionality. I was hoping to use this in combination with `curl`.

"create or update" operation for device registry

It might make the implementation of `drg` a bit simpler :)

add CORS to http endpoint

I think you need to rebase the PR

add basic spinner

I really appreciate the effort, implementing the "legacy" part too. However (unless you do need it) I would suggest to drop it. I done so, the be easy to change...