Lucian Ilie

Results 6 comments of Lucian Ilie

Thanks for your comments! Sure @amuraru. Just to double check, I think that @stoader was referring to leave it false by default and let clients pass it via operator config....

Thinking about it, it is basically the same as you meant @amuraru. I will amend the PR.

@panyuenlau I will follow up next week with a new commit. I am on holiday this week. I had a commit prepared, just needed to change some tests too.

> @ctrlaltluc Thanks for the info and we look forward to the update! @panyuenlau I updated the PR according to the previous comments. Thanks for your patience!

> @ctrlaltluc Can you please update [this sample KafkaCluster yaml](https://github.com/banzaicloud/koperator/blob/master/config/samples/banzaicloud_v1beta1_kafkacluster.yaml#L238) to reflect the newly added field? @panyuenlau Managed to add it in [48a78f3](https://github.com/banzaicloud/koperator/pull/830/commits/48a78f36bff35c9126e7b14208e3bb19c94f1252).

@panyuenlau the PR is ready to be merged now. :)