Christian Henkel comments

Results 77 comments of


                                            Christian Henkel

Our software should be production ready

nvm

Python DiagnosedPublisher crashes on publishing headerless topic

@JamesOwensMTC Thanks for reporting this. What is your suggestion to fix this?

Port hd_monitor to ROS2

Thanks for your contribution @limaanto :) Please add also a test. But you should be able to adopt https://github.com/ros/diagnostics/blob/ros2/diagnostic_common_diagnostics/test/systemtest/test_ntp_monitor_launchtest.py directly.

Updater::add to take ownership of FunctionDiagnosticTask

Thanks for your issue, @russkel. Could you please describe what you are trying to achieve in more detail? What is `ivp_diag`? Please feel free to provide a test that and...

Migrate hd_monitor.py to ROS2

Hi @limaanto Thanks for your interest in working on this. 1. I was not involved with that. But I think the main point was, that it was unmanageably big. So...

Make diagnostic aggregator composable

Hi @jlack1987 Thanks for bringing this up. I agree that this would be useful. Especially when paired with the node that is diagnosed, this would save some overhead. Pull requests...

Four speed improvements

😁

Could not find the required component 'diagnostic_updater'.

Sorry @jagauthier, but I can not reproduce this. Can you describe your setup, please, and tell me under which revision this happened?

ROS2 Missing ament_export_target in diagnostic_aggregation CMake

I agree. I think we can close this

Old-style python classes

Hi @scottnothing. Could you please give an example?