Charles Strahan

Results 110 comments of Charles Strahan

Going to work around things for now with this in `go.mod`: ``` replace git.apache.org/thrift.git => github.com/apache/thrift v0.0.0-20180902110319-2566ecd5d999 ```

So, the `gomod2nix.toml` definitely works. To get the builder using `fetchGit`, I just did: ```patch diff --git a/builder/default.nix b/builder/default.nix index bfe3298..87d47a5 100644 --- a/builder/default.nix +++ b/builder/default.nix @@ -50,9 +50,9 @@...

Speaking of the tests, maybe the `-c` flag could be used for what I described above: ``` -c Compile the test binary to pkg.test but do not run it (where...

Maybe something like `go list -f '{{.Name}}' $pkg` would be better than `$(basename $pkg)` -- would work for top level of source tree, and I think reflects what `go test...

Made a couple quick hacks to get the tests built in a `$test` output: ```nix outputs = [ "out" "test" ]; checkPhase = attrs.checkPhase or '' runHook preCheck for pkg...

Ah, I just realized we can pass `narHash` to `fetchGit`. I'll see if that's something I can add.

We probably ought to default it to `/dev/null`, but provide a flag to choose the config. My team makes use of an internal registry of private packages, so we'd need...

FWIW, you might find some inspiration here: https://bitbucket.org/ZyX_I/zsh/src/zpython/Src/Modules/zpython.c

Is there anything I can do to help move this along?

Ruby switched from oniguruma to onigmo (a fork of oniguruma) in Ruby 2.0, released 24 February 2013. With [very few documented exceptions](https://github.com/k-takata/Onigmo/wiki/incompat) excepted, onigmo should provide a superset of of...