Christoph Stich comments

Repositories
Issues
Comments

Results 26 comments of


                                            Christoph Stich

Write tests

We should add tests to make sure we are dealing with holes in the original data correctly.

Outdated data

Thanks for this. We are still using the old data.

Optional dependencies

Will do that then for the next major release.

all of China should be +0800, but some are showing up as +0600

Can you elaborate why you think all of China should be +0800? In our source [data](http://efele.net/maps/tz/world/), China does have several timezones.

all of China should be +0800, but some are showing up as +0600

@mikofski If you can report back what Eric Muller says that would be great.

forceTZ returning unexpected result

I am not completely sure why it doesn't return the correct timezone either. I'll have a look into it.