Andrew Bradley

Results 546 comments of Andrew Bradley
trafficstars

I hit a similar issue with [Satori Reader](https://www.satorireader.com/). For each kanji, it uses markup to include multiple possible representations: kana and kanji. CSS rules selectively show only one of them....

In the interim, [@cspotcode/source-map-support]() may work as a drop-in replacement. I'm not 100% sure, but I checked the code and I don't think it has the `fetch` check. Might not...

Looks to be functionally identical to https://github.com/esvit/ng-ckeditor/pull/25 and https://github.com/esvit/ng-ckeditor/pull/23

I'd also be curious to hear if anyone compares the performance of `source-map-support` against [`@cspotcode/source-map-support`](npm.im/@cspotcode/source-map-support). We use a newer version of the underlying source-map consumer which has some WASM components...

Thanks for putting that together; I posted a few questions here: mjpowersjr/source-map-performance-demo#1 Some of the comparisons appear to be apples-and-oranges, which is not at all a bad thing, but it...

I have updated the benchmark to fix bugs and test that the generated stack traces are correct: https://github.com/mjpowersjr/source-map-performance-demo/pull/2 https://github.com/nodejs/node/issues/42417#issuecomment-1079374441 Both `--enable-source-maps` and `-r source-map-support/register` emit incorrect stack traces. `-r @cspotcode/source-map-support/register`...

To fix this, the implementation of `CallSiteToString` -- which is copy-pasted from V8 source code -- must be updated to match the latest V8 implementation. https://github.com/v8/v8/blob/dc712da548c7fb433caed56af9a021d964952728/src/objects/stack-frame-info.cc#L344-L393

I noticed that any workflows which cannot be executed are immediately closed. Should they be left open? If, due to some operational hiccup, the worker believes it cannot execute a...

Sounds good to me, agreed that iterating is easier for the ecosystem than batching. I also suspect the off-thread changes are gonna need more work till they're merge-able.

Well, all the internal CJS resolver functions are still private, so that's not the best example.