csharper2010

Results 6 comments of csharper2010

Yes, i did not consider private protected... could add that in another step. So if there is at least one private protected constructor and all constructors are private or private...

If you don't provide all branchs in the ClosedAttribute, how should the analyzer know that Success is the only other subclass of the record. See my issue #44 on how...

@WalkerCodeRanger Are there chances to get a current build soon published to nuget? Do you have open things to do where I could support?

Sorry for not seeing this... Adding the logic directly to the AbstractStringType is surely better. One question: should we make it more explicit for Enums because the Convert.ToType is very...

> > > @fredericDelaporte @gliljas please check. This change is consistent with how some other types handle parameters, for example: > > https://github.com/nhibernate/nhibernate-core/blob/7f60bc3a875a721d6ad4b76b530f2447da79454f/src/NHibernate/Type/Int32Type.cs#L59-L62 Sorry for picking up that discussion that...

Hi again, I would like to pick that up again... Should I revert the change back to the original one with just handling Enums? Do I have a chance to...