Christopher L. Shannon

Results 148 comments of Christopher L. Shannon

@ctubbsii - I am going to open a new pull request when I am finished with my changes. How do you want me to handle the history here? Should I...

@ctubbsii - Can you go ahead and assign this issue for me to work on? This issue looks like something interesting for me to dive into for the 3.0 release...

@gemmellr or @tabish121 - Can one (or both) of you take a look when you get a chance? Since you have had a ton of expeirnece with the JMS 2.0...

For context this PR builds on this commit it looks like: https://github.com/apache/activemq/commit/67256c6

@mattrpav - it would probably make sense to take a look at Qpid JMS and Artemis implementations for the JMS 2.0 api. You can probably just copy a lot of...

Yeah I am a -1 on such a big change like this (adding an entire new store) without a discussion first. I find it highly unlikely this will be maintained...

The build is broken due to 5.18.0 been broken in main (the version was bumped today). There's an issue with the maven build that caused it to not build all...

Agree with @jbonofre, I think having a configuration option makes no sense. ~~Just change it but at this point it should be target for 5.18 as 5.17 should be frozen...

This change itself seems fine but I'm not sure if any existing network bridge tests will break. So you need to check all the network tests and run them to...

The main issue I see here is what you pointed out...while this prevents the error it would result in not filtering between brokers and may cause unintended behavior which isn't...