activemq icon indicating copy to clipboard operation
activemq copied to clipboard

AMQ-8317 add config param to toggle inclusive terms in logs

Open ehossack-aws opened this issue 3 years ago • 6 comments

As suggested in #679 , this adds a log toggle config to allow users to opt back in to the non-inclusive terminology previously used, as the messages may be used in monitoring/alerting.

ehossack-aws avatar Sep 23 '21 13:09 ehossack-aws

Not super sure the best way to chain commits without a target branch, so linking the new commit in this pr: https://github.com/apache/activemq/pull/714/commits/3f7eb0a39ba3e7926e72f91fa3f9f6748e261726

ehossack-aws avatar Sep 23 '21 13:09 ehossack-aws

It looks good to me and a good idea. Can you please squash the three commits ? Thanks

jbonofre avatar Oct 25 '21 04:10 jbonofre

It looks good to me and a good idea. Can you please squash the three commits ? Thanks

Can we merge https://github.com/apache/activemq/pull/700 first? That is the parent to this PR.

ehossack-aws avatar Oct 25 '21 16:10 ehossack-aws

Please hold on merge, need to review the terminology.

mattrpav avatar Jan 24 '22 16:01 mattrpav

To be honest, I'm not a big fan of having a configuration for that. I think we can just go for the change for ActiveMQ 5.17.x and keep as it is on 5.16.x.

jbonofre avatar Jan 24 '22 17:01 jbonofre

Agree with @jbonofre, I think having a configuration option makes no sense. ~~Just change it but at this point it should be target for 5.18 as 5.17 should be frozen except for critical stuff~~ I think we can include it in 5.17.0 since it's just logging if you want to but in my opinion it should have the toggle/flag option removed as discussed on the dev list thread.

cshannon avatar Mar 01 '22 18:03 cshannon

It will superseded by another PR for 7.0.0 with directly terminology change.

jbonofre avatar Oct 20 '23 05:10 jbonofre