Corey DeChant
Corey DeChant
The naming convention suggested seems good to me. Also, I am including @cticenhour and @keniley1, in case they have some input (I saw that you included me twice in a...
In terms of PR, I believe this should just be one PR for the whole issue (so include all BCs, Kernels, Materials, etc.). If you want to reduce initial review...
> I personally prefer being able to review a complete, submitted and tested PR, rather than doing reviews as more commits are added. The PRs are smaller and more digestible....
I add the DOI to the BCs that I thought were novel enough (basically BCs you wouldn't just found in a text book). To found the DOI for the BCs...
Just a reminder for our email conversation, I haven't fully proofread the documentation, so please excuse any typos/left over self-notes.
@gsgall @cticenhour This PR is ready for another review. There are some unresolved conversations that focuses on formatting, but nothing too big.
@cticenhour Your edits to CIVET seemed to work, as this branch fails precheck due to not referencing an issue number. I will edit the last commit message to reference issue...
@gsgall That should be all the new edits. If there is nothing else, I think this PR is ready to go.
> Looks good to me. Thank you @csdechant. I think we just need @cticenhour to do a review since I don't have merge permission. Yes, you still only have Triage...
@gsgall you should official have Admin rights now. This PR is showing all green on my end, indicating GitHub accepts the role changes for this PR.