Carmine Scarpitta

Results 34 comments of Carmine Scarpitta

This PR includes some features already proposed in PR #11348. We waited a long time for the PR #11348 to be merged, but we saw that there has been no...

Hi @donaldsharp , thanks for your comment. Let me give some context. I'm not the author of the other PR (#11348). I got aware of it when I was preparing...

Hi @ton31337, many thanks for your review. I addressed all your comments and fixed most of the warnings reported by frrbot and CI. Regarding the CI, 3 style warnings remain...

> @cscarpitta could you squash or amend the last commits to the right ones because they are just garbage (a burden to backport/revert things in the future)? @ton31337 Done! I...

> I'm seeing memory leaks when I run the new tests with --valgrind-memleaks: > > ==63389== 704 (344 direct, 360 indirect) bytes in 1 blocks are definitely lost in loss...

> I don't see anything beyond what Donald has already commented on ... will wait for those to be resolved and look again @riw777 Thanks for the review. I already...

> Can you rebase again? @ton31337 I rebased on master. Thanks.