bgpd: add support for SRv6 L3VPN for IPv4 and IPv6 address families using a single SID

[cscarpitta]

This PR introduces the following changes in FRR:

• add new optional CLI arguments block-len and node-len to make the block length and node length of an SRv6 locator configurable
• add support for SRv6 End.DT46 behavior (both in zebra and sharpd)
• add a CLI command to configure a per-VRF SRv6 SID in bgpd (used to advertise a L3VPN for IPv4 and IPv6 address families using a single SID (End.DT46)
• add block/node/func/arg length to the output returned by show bgp segment-routing srv6
• add per-VRF SRv6 SID to the output returned by show bgp segment-routing srv6
• change bgpd to advertise block/node/func/arg length configured in the SRv6 locator instead of the hardcoded default values
• add a new topotest for SRv6 L3VPN for IPv4 and IPv6 address families using a single SID
• add a new topotest to verify the block-len and node-len parameters of an SRv6 locator
• add a new topotest to verify the End.DT46 seg6local routes
• add documentation for all new features (bgpd, sharpd, and zebra)

Signed-off-by: Carmine Scarpitta [email protected]

[cscarpitta]

This PR includes some features already proposed in PR #11348. We waited a long time for the PR #11348 to be merged, but we saw that there has been no progress for some time. If the PR #11348 is merged in the meantime we are ready to rebase and resubmit our changes.

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6630/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6630/artifact/TOPO7U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 7: No useful log found

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6630/artifact/TOPO7U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 7: No useful log found

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Topotests debian 10 amd64 part 7: Failed (click for details)

Topotests debian 10 amd64 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6630/artifact/TOPO7DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 7: No useful log found

Successful on other platforms/tests

• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests debian 10 amd64 part 9
• Addresssanitizer topotests part 5
• IPv4 ldp protocol on Ubuntu 18.04
• Topotests Ubuntu 18.04 amd64 part 2
• Ubuntu 16.04 deb pkg check
• Debian 10 deb pkg check
• Topotests debian 10 amd64 part 8
• IPv6 protocols on Ubuntu 18.04
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 amd64 part 4
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 9
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 amd64 part 5
• Ubuntu 20.04 deb pkg check
• IPv4 protocols on Ubuntu 18.04
• Addresssanitizer topotests part 3
• Fedora 29 rpm pkg check
• Addresssanitizer topotests part 9
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 amd64 part 9
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 arm8 part 5
• CentOS 7 rpm pkg check
• Topotests Ubuntu 18.04 i386 part 9
• Addresssanitizer topotests part 6
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 5
• Static analyzer (clang)
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 i386 part 0
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests debian 10 amd64 part 2
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 6
• Ubuntu 18.04 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 1
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests debian 10 amd64 part 6
• Addresssanitizer topotests part 4
• Debian 9 deb pkg check
• Topotests debian 10 amd64 part 5
• Addresssanitizer topotests part 8

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 i386 part 7: Failed (click for details)

Topotests Ubuntu 18.04 i386 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6630/artifact/TOPO7U18I386/ErrorLog/ Topotests Ubuntu 18.04 i386 part 7: No useful log found

Topotests Ubuntu 18.04 amd64 part 7: Failed (click for details)

Topotests Ubuntu 18.04 amd64 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6630/artifact/TOPO7U18AMD64/ErrorLog/ Topotests Ubuntu 18.04 amd64 part 7: No useful log found

Topotests Ubuntu 18.04 arm8 part 7: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 7: No useful log found

Topotests debian 10 amd64 part 7: Failed (click for details)

Topotests debian 10 amd64 part 7: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6630/artifact/TOPO7DEB10AMD64/ErrorLog/ Topotests debian 10 amd64 part 7: No useful log found

<stdin>:4986: trailing whitespace.
    
<stdin>:5012: trailing whitespace.
    
<stdin>:5374: new blank line at EOF.
+
<stdin>:5415: new blank line at EOF.
+
<stdin>:5426: new blank line at EOF.
+
warning: 5 lines add whitespace errors.
Report for bgp_mplsvpn.c | 12 issues
===============================================
< WARNING: line over 80 characters
< #1482: FILE: /tmp/f1-32183/bgp_mplsvpn.c:1482:
< WARNING: line over 80 characters
< #1485: FILE: /tmp/f1-32183/bgp_mplsvpn.c:1485:
< WARNING: line over 80 characters
< #1496: FILE: /tmp/f1-32183/bgp_mplsvpn.c:1496:
< WARNING: line over 80 characters
< #1551: FILE: /tmp/f1-32183/bgp_mplsvpn.c:1551:
< WARNING: line over 80 characters
< #1554: FILE: /tmp/f1-32183/bgp_mplsvpn.c:1554:
< WARNING: line over 80 characters
< #1565: FILE: /tmp/f1-32183/bgp_mplsvpn.c:1565:
Report for bgp_vty.c | 4 issues
===============================================
< WARNING: line over 80 characters
< #9852: FILE: /tmp/f1-32183/bgp_vty.c:9852:
< WARNING: line over 80 characters
< #17818: FILE: /tmp/f1-32183/bgp_vty.c:17818:
Report for bgp_zebra.c | 2 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #3264: FILE: /tmp/f1-32183/bgp_zebra.c:3264:
Report for rt_netlink.c | 10 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2727: FILE: /tmp/f1-32183/rt_netlink.c:2727:
< WARNING: line over 80 characters
< #2729: FILE: /tmp/f1-32183/rt_netlink.c:2729:
< WARNING: line over 80 characters
< #2730: FILE: /tmp/f1-32183/rt_netlink.c:2730:
< WARNING: Too many leading tabs - consider code refactoring
< #2732: FILE: /tmp/f1-32183/rt_netlink.c:2732:
< WARNING: line over 80 characters
< #2734: FILE: /tmp/f1-32183/rt_netlink.c:2734:

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6631/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

<stdin>:4985: trailing whitespace.
    
<stdin>:5011: trailing whitespace.
    
<stdin>:5373: new blank line at EOF.
+
<stdin>:5414: new blank line at EOF.
+
<stdin>:5425: new blank line at EOF.
+
warning: 5 lines add whitespace errors.
Report for bgp_mplsvpn.c | 12 issues
===============================================
< WARNING: line over 80 characters
< #1482: FILE: /tmp/f1-22064/bgp_mplsvpn.c:1482:
< WARNING: line over 80 characters
< #1485: FILE: /tmp/f1-22064/bgp_mplsvpn.c:1485:
< WARNING: line over 80 characters
< #1496: FILE: /tmp/f1-22064/bgp_mplsvpn.c:1496:
< WARNING: line over 80 characters
< #1551: FILE: /tmp/f1-22064/bgp_mplsvpn.c:1551:
< WARNING: line over 80 characters
< #1554: FILE: /tmp/f1-22064/bgp_mplsvpn.c:1554:
< WARNING: line over 80 characters
< #1565: FILE: /tmp/f1-22064/bgp_mplsvpn.c:1565:
Report for bgp_zebra.c | 2 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #3264: FILE: /tmp/f1-22064/bgp_zebra.c:3264:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2727: FILE: /tmp/f1-22064/rt_netlink.c:2727:
< WARNING: line over 80 characters
< #2730: FILE: /tmp/f1-22064/rt_netlink.c:2730:
< WARNING: Too many leading tabs - consider code refactoring
< #2732: FILE: /tmp/f1-22064/rt_netlink.c:2732:

[donaldsharp]

The other PR is not being merged because you haven't answered @ton31337 's question yet. You need to work it out with him. All in all I agree with him, I don't understand what that function is trying to do or why.

[cscarpitta]

Hi @donaldsharp ,

thanks for your comment.

Let me give some context.

I'm not the author of the other PR (#11348). I got aware of it when I was preparing this PR. Anyway, some of the features included in the other PR are already supported in my PR.

My PR is part of the work on the integration of FRR and SONiC to support SRv6 ( https://github.com/sonic-net/SONiC/blob/master/doc/srv6/srv6_hld.md).

The SRv6 Network Programming model allows the support of L3VPN services for IPv4 and IPv6 address families using a single SRv6 SID (https://datatracker.ietf.org/doc/html/rfc8986#section-4.8).

In the current implementation of FRR/bgpd, you can export VPN routes using a per-address-family SRv6 SID (a SID for the IPv4 routes, a second SID for the IPv6 routes).

In my PR, I extended bgpd to export VPN routes for both IPv4 and IPv6 address families using a single SID (instead of using two SIDs). This is in alignment with SRv6 Network Programming model (RFC8986).

As part of my PR, I added some updates to zebra and bgpd including:

• Update bgpd to advertise block/node/func/arg length configured in the SRv6 locator instead of the hardcoded default values (https://datatracker.ietf.org/doc/html/rfc9252#section-3.2.1).

This is the only change that overlaps between my PR and the other PR (#11348). All the other changes proposed in my PR are not included in the other PR.

Regards, Carmine

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6812/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

Successful on other platforms/tests

• Topotests Ubuntu 18.04 i386 part 9
• Topotests debian 10 amd64 part 2
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 amd64 part 8
• Addresssanitizer topotests part 8
• Static analyzer (clang)
• Topotests Ubuntu 18.04 amd64 part 9
• Ubuntu 20.04 deb pkg check
• Topotests Ubuntu 18.04 i386 part 0
• Ubuntu 18.04 deb pkg check
• Debian 10 deb pkg check
• Addresssanitizer topotests part 6
• Topotests Ubuntu 18.04 arm8 part 5
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 6
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 amd64 part 6
• Addresssanitizer topotests part 0
• Debian 9 deb pkg check
• Addresssanitizer topotests part 4
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests debian 10 amd64 part 4
• Addresssanitizer topotests part 9
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests debian 10 amd64 part 5
• Topotests Ubuntu 18.04 arm8 part 7
• Topotests debian 10 amd64 part 0
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 amd64 part 5
• IPv4 ldp protocol on Ubuntu 18.04
• Ubuntu 16.04 deb pkg check
• Topotests Ubuntu 18.04 i386 part 7
• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests debian 10 amd64 part 8
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 i386 part 5
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 arm8 part 9
• Addresssanitizer topotests part 2
• IPv6 protocols on Ubuntu 18.04
• Topotests Ubuntu 18.04 amd64 part 4
• CentOS 7 rpm pkg check
• Fedora 29 rpm pkg check
• IPv4 protocols on Ubuntu 18.04

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 8: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 8: No useful log found

<stdin>:4978: trailing whitespace.
    
<stdin>:5004: trailing whitespace.
    
<stdin>:5366: new blank line at EOF.
+
<stdin>:5407: new blank line at EOF.
+
<stdin>:5418: new blank line at EOF.
+
warning: 5 lines add whitespace errors.
Report for bgp_mplsvpn.c | 10 issues
===============================================
< WARNING: line over 80 characters
< #439: FILE: /tmp/f1-12245/bgp_mplsvpn.c:439:
< WARNING: line over 80 characters
< #791: FILE: /tmp/f1-12245/bgp_mplsvpn.c:791:
< WARNING: line over 80 characters
< #799: FILE: /tmp/f1-12245/bgp_mplsvpn.c:799:
< WARNING: suspect code indent for conditional statements (24, 24)
< #1486: FILE: /tmp/f1-12245/bgp_mplsvpn.c:1486:
< WARNING: line over 80 characters
< #1551: FILE: /tmp/f1-12245/bgp_mplsvpn.c:1551:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2727: FILE: /tmp/f1-12245/rt_netlink.c:2727:
< WARNING: line over 80 characters
< #2730: FILE: /tmp/f1-12245/rt_netlink.c:2730:
< WARNING: Too many leading tabs - consider code refactoring
< #2732: FILE: /tmp/f1-12245/rt_netlink.c:2732:

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6813/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-6813/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6813/artifact/TOPOU1804/ErrorLog/log_topotests.txt

Successful on other platforms/tests

• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 9
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 i386 part 9
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 amd64 part 8
• Addresssanitizer topotests part 8
• Static analyzer (clang)
• Topotests Ubuntu 18.04 i386 part 0
• Ubuntu 18.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Addresssanitizer topotests part 6
• Debian 10 deb pkg check
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 arm8 part 5
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 6
• Topotests Ubuntu 18.04 amd64 part 6
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 3
• Addresssanitizer topotests part 4
• Topotests Ubuntu 18.04 arm8 part 3
• Topotests debian 10 amd64 part 5
• Debian 9 deb pkg check
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests debian 10 amd64 part 4
• Addresssanitizer topotests part 9
• Topotests Ubuntu 18.04 amd64 part 3
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 arm8 part 2
• Topotests Ubuntu 18.04 arm8 part 7
• Topotests debian 10 amd64 part 0
• Addresssanitizer topotests part 7
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 amd64 part 5
• IPv4 ldp protocol on Ubuntu 18.04
• Ubuntu 16.04 deb pkg check
• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests Ubuntu 18.04 i386 part 3
• Topotests debian 10 amd64 part 8
• Addresssanitizer topotests part 3
• Topotests Ubuntu 18.04 amd64 part 7
• IPv6 protocols on Ubuntu 18.04
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 i386 part 5
• Topotests Ubuntu 18.04 arm8 part 9
• Addresssanitizer topotests part 2
• Topotests debian 10 amd64 part 9
• IPv4 protocols on Ubuntu 18.04
• Topotests Ubuntu 18.04 amd64 part 4
• CentOS 7 rpm pkg check
• Fedora 29 rpm pkg check

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-6813/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-6813/artifact/TOPOU1804/ErrorLog/log_topotests.txt

<stdin>:4981: trailing whitespace.
    
<stdin>:5007: trailing whitespace.
    
<stdin>:5369: new blank line at EOF.
+
<stdin>:5410: new blank line at EOF.
+
<stdin>:5421: new blank line at EOF.
+
warning: 5 lines add whitespace errors.
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2727: FILE: /tmp/f1-4369/rt_netlink.c:2727:
< WARNING: line over 80 characters
< #2730: FILE: /tmp/f1-4369/rt_netlink.c:2730:
< WARNING: Too many leading tabs - consider code refactoring
< #2732: FILE: /tmp/f1-4369/rt_netlink.c:2732:

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6814/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

<stdin>:4981: trailing whitespace.
    
<stdin>:5007: trailing whitespace.
    
<stdin>:5369: new blank line at EOF.
+
<stdin>:5410: new blank line at EOF.
+
<stdin>:5421: new blank line at EOF.
+
warning: 5 lines add whitespace errors.
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2727: FILE: /tmp/f1-9864/rt_netlink.c:2727:
< WARNING: line over 80 characters
< #2730: FILE: /tmp/f1-9864/rt_netlink.c:2730:
< WARNING: Too many leading tabs - consider code refactoring
< #2732: FILE: /tmp/f1-9864/rt_netlink.c:2732:

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6818/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2727: FILE: /tmp/f1-29867/rt_netlink.c:2727:
< WARNING: line over 80 characters
< #2730: FILE: /tmp/f1-29867/rt_netlink.c:2730:
< WARNING: Too many leading tabs - consider code refactoring
< #2732: FILE: /tmp/f1-29867/rt_netlink.c:2732:

[cscarpitta]

Hi @ton31337, many thanks for your review.

I addressed all your comments and fixed most of the warnings reported by frrbot and CI.

Regarding the CI, 3 style warnings remain unresolved. These warnings are related to the rt_netlink.c file. To fix them, we need a code refactor that goes beyond this PR, because the warnings are related to code that was already present. In my opinion, it is more appropriate to open a separate pull request to fix these style issues. I can open a new PR and do some code refactor after this PR is merged.

Concerning the warnings reported by frrbot, some of these are related to bgp_vty.c and zebra_vty.c, and I think these warnings are going in the wrong direction. The others are related to header files taken from the Linux kernel and (in my opinion) it is not worth fixing them.

Let me know what you think.

[ton31337]

@cscarpitta could you squash or amend the last commits to the right ones because they are just garbage (a burden to backport/revert things in the future)?

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-6838/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2727: FILE: /tmp/f1-12118/rt_netlink.c:2727:
< WARNING: line over 80 characters
< #2730: FILE: /tmp/f1-12118/rt_netlink.c:2730:
< WARNING: Too many leading tabs - consider code refactoring
< #2732: FILE: /tmp/f1-12118/rt_netlink.c:2732:

[cscarpitta]

@cscarpitta could you squash or amend the last commits to the right ones because they are just garbage (a burden to backport/revert things in the future)?

@ton31337 Done! I squashed both the last and style-related commits to the right ones and force-pushed the branch.

[donaldsharp]

I'm seeing memory leaks when I run the new tests with --valgrind-memleaks:

==63389== 704 (344 direct, 360 indirect) bytes in 1 blocks are definitely lost in loss record 26 of 30 ==63389== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63389== by 0x4910261: qcalloc (memory.c:116) ==63389== by 0x491208E: srv6_locator_alloc (srv6.c:132) ==63389== by 0x1EEF05: srv6_locator (zebra_srv6_vty.c:247) ==63389== by 0x48C9423: cmd_execute_command_real (command.c:997) ==63389== by 0x48C96FC: cmd_execute_command_strict (command.c:1108) ==63389== by 0x48C9B94: command_config_read_one_line (command.c:1268) ==63389== by 0x48C9D09: config_from_file (command.c:1313) ==63389== by 0x496B831: vty_read_file (vty.c:2347) ==63389== by 0x496C01F: vty_read_config (vty.c:2567) ==63389== by 0x48FED1C: frr_config_read_in (libfrr.c:984) ==63389== by 0x496118F: thread_call (thread.c:2005) ==63389== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63389== by 0x1A11F3: main (main.c:475) ==63389== ==63389== 704 (344 direct, 360 indirect) bytes in 1 blocks are definitely lost in loss record 27 of 30 ==63389== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63389== by 0x4910261: qcalloc (memory.c:116) ==63389== by 0x491208E: srv6_locator_alloc (srv6.c:132) ==63389== by 0x1EEF05: srv6_locator (zebra_srv6_vty.c:247) ==63389== by 0x48C9423: cmd_execute_command_real (command.c:997) ==63389== by 0x48C9BBC: command_config_read_one_line (command.c:1280) ==63389== by 0x48C9D09: config_from_file (command.c:1313) ==63389== by 0x496B831: vty_read_file (vty.c:2347) ==63389== by 0x496C01F: vty_read_config (vty.c:2567) ==63389== by 0x48FED1C: frr_config_read_in (libfrr.c:984) ==63389== by 0x496118F: thread_call (thread.c:2005) ==63389== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63389== by 0x1A11F3: main (main.c:475) ==63389== ==63389== 704 (344 direct, 360 indirect) bytes in 1 blocks are definitely lost in loss record 28 of 30 ==63389== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63389== by 0x4910261: qcalloc (memory.c:116) ==63389== by 0x491208E: srv6_locator_alloc (srv6.c:132) ==63389== by 0x1EEF05: srv6_locator (zebra_srv6_vty.c:247) ==63389== by 0x48C9423: cmd_execute_command_real (command.c:997) ==63389== by 0x48C9590: cmd_execute_command (command.c:1057) ==63389== by 0x48C9AEA: cmd_execute (command.c:1224) ==63389== by 0x49676F3: vty_command (vty.c:482) ==63389== by 0x496948C: vty_execute (vty.c:1245) ==63389== by 0x496B2B4: vtysh_read (vty.c:2144) ==63389== by 0x496118F: thread_call (thread.c:2005) ==63389== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63389== by 0x1A11F3: main (main.c:475) ==63426== 56 bytes in 1 blocks are definitely lost in loss record 11 of 38 ==63426== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63426== by 0x4910261: qcalloc (memory.c:116) ==63426== by 0x492F7BA: prefix_new (prefix.c:1141) ==63426== by 0x492E746: prefix_ipv6_new (prefix.c:715) ==63426== by 0x1137E5: sharp_zebra_process_srv6_locator_chunk (sharp_zebra.c:963) ==63426== by 0x49806E9: zclient_read (zclient.c:3992) ==63426== by 0x496118F: thread_call (thread.c:2005) ==63426== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63426== by 0x110CDC: main (sharp_main.c:192) ==63426== ==63426== 264 bytes in 1 blocks are definitely lost in loss record 27 of 38 ==63426== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63426== by 0x4910261: qcalloc (memory.c:116) ==63426== by 0x11B7F1: sharp_srv6_manager_get_locator_chunk_magic (sharp_vty.c:953) ==63426== by 0x11952C: sharp_srv6_manager_get_locator_chunk (sharp_vty_clippy.c:1619) ==63426== by 0x48C9423: cmd_execute_command_real (command.c:997) ==63426== by 0x48C9590: cmd_execute_command (command.c:1057) ==63426== by 0x48C9AEA: cmd_execute (command.c:1224) ==63426== by 0x49676F3: vty_command (vty.c:482) ==63426== by 0x496948C: vty_execute (vty.c:1245) ==63426== by 0x496B2B4: vtysh_read (vty.c:2144) ==63426== by 0x496118F: thread_call (thread.c:2005) ==63426== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63426== by 0x110CDC: main (sharp_main.c:192)

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7049/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2720: FILE: /tmp/f1-4995/rt_netlink.c:2720:
< WARNING: line over 80 characters
< #2723: FILE: /tmp/f1-4995/rt_netlink.c:2723:
< WARNING: Too many leading tabs - consider code refactoring
< #2725: FILE: /tmp/f1-4995/rt_netlink.c:2725:

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7057/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for bgp_zebra.c | 4 issues
===============================================
< WARNING: C99 // comments do not match recommendation
< #3277: FILE: /tmp/f1-6841/bgp_zebra.c:3277:
< WARNING: C99 // comments do not match recommendation
< #3282: FILE: /tmp/f1-6841/bgp_zebra.c:3282:
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2720: FILE: /tmp/f1-6841/rt_netlink.c:2720:
< WARNING: line over 80 characters
< #2723: FILE: /tmp/f1-6841/rt_netlink.c:2723:
< WARNING: Too many leading tabs - consider code refactoring
< #2725: FILE: /tmp/f1-6841/rt_netlink.c:2725:

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7064/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2720: FILE: /tmp/f1-19374/rt_netlink.c:2720:
< WARNING: line over 80 characters
< #2723: FILE: /tmp/f1-19374/rt_netlink.c:2723:
< WARNING: Too many leading tabs - consider code refactoring
< #2725: FILE: /tmp/f1-19374/rt_netlink.c:2725:

[cscarpitta]

I'm seeing memory leaks when I run the new tests with --valgrind-memleaks:

==63389== 704 (344 direct, 360 indirect) bytes in 1 blocks are definitely lost in loss record 26 of 30 ==63389== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63389== by 0x4910261: qcalloc (memory.c:116) ==63389== by 0x491208E: srv6_locator_alloc (srv6.c:132) ==63389== by 0x1EEF05: srv6_locator (zebra_srv6_vty.c:247) ==63389== by 0x48C9423: cmd_execute_command_real (command.c:997) ==63389== by 0x48C96FC: cmd_execute_command_strict (command.c:1108) ==63389== by 0x48C9B94: command_config_read_one_line (command.c:1268) ==63389== by 0x48C9D09: config_from_file (command.c:1313) ==63389== by 0x496B831: vty_read_file (vty.c:2347) ==63389== by 0x496C01F: vty_read_config (vty.c:2567) ==63389== by 0x48FED1C: frr_config_read_in (libfrr.c:984) ==63389== by 0x496118F: thread_call (thread.c:2005) ==63389== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63389== by 0x1A11F3: main (main.c:475) ==63389== ==63389== 704 (344 direct, 360 indirect) bytes in 1 blocks are definitely lost in loss record 27 of 30 ==63389== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63389== by 0x4910261: qcalloc (memory.c:116) ==63389== by 0x491208E: srv6_locator_alloc (srv6.c:132) ==63389== by 0x1EEF05: srv6_locator (zebra_srv6_vty.c:247) ==63389== by 0x48C9423: cmd_execute_command_real (command.c:997) ==63389== by 0x48C9BBC: command_config_read_one_line (command.c:1280) ==63389== by 0x48C9D09: config_from_file (command.c:1313) ==63389== by 0x496B831: vty_read_file (vty.c:2347) ==63389== by 0x496C01F: vty_read_config (vty.c:2567) ==63389== by 0x48FED1C: frr_config_read_in (libfrr.c:984) ==63389== by 0x496118F: thread_call (thread.c:2005) ==63389== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63389== by 0x1A11F3: main (main.c:475) ==63389== ==63389== 704 (344 direct, 360 indirect) bytes in 1 blocks are definitely lost in loss record 28 of 30 ==63389== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63389== by 0x4910261: qcalloc (memory.c:116) ==63389== by 0x491208E: srv6_locator_alloc (srv6.c:132) ==63389== by 0x1EEF05: srv6_locator (zebra_srv6_vty.c:247) ==63389== by 0x48C9423: cmd_execute_command_real (command.c:997) ==63389== by 0x48C9590: cmd_execute_command (command.c:1057) ==63389== by 0x48C9AEA: cmd_execute (command.c:1224) ==63389== by 0x49676F3: vty_command (vty.c:482) ==63389== by 0x496948C: vty_execute (vty.c:1245) ==63389== by 0x496B2B4: vtysh_read (vty.c:2144) ==63389== by 0x496118F: thread_call (thread.c:2005) ==63389== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63389== by 0x1A11F3: main (main.c:475) ==63426== 56 bytes in 1 blocks are definitely lost in loss record 11 of 38 ==63426== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63426== by 0x4910261: qcalloc (memory.c:116) ==63426== by 0x492F7BA: prefix_new (prefix.c:1141) ==63426== by 0x492E746: prefix_ipv6_new (prefix.c:715) ==63426== by 0x1137E5: sharp_zebra_process_srv6_locator_chunk (sharp_zebra.c:963) ==63426== by 0x49806E9: zclient_read (zclient.c:3992) ==63426== by 0x496118F: thread_call (thread.c:2005) ==63426== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63426== by 0x110CDC: main (sharp_main.c:192) ==63426== ==63426== 264 bytes in 1 blocks are definitely lost in loss record 27 of 38 ==63426== at 0x48455EF: calloc (vg_replace_malloc.c:1328) ==63426== by 0x4910261: qcalloc (memory.c:116) ==63426== by 0x11B7F1: sharp_srv6_manager_get_locator_chunk_magic (sharp_vty.c:953) ==63426== by 0x11952C: sharp_srv6_manager_get_locator_chunk (sharp_vty_clippy.c:1619) ==63426== by 0x48C9423: cmd_execute_command_real (command.c:997) ==63426== by 0x48C9590: cmd_execute_command (command.c:1057) ==63426== by 0x48C9AEA: cmd_execute (command.c:1224) ==63426== by 0x49676F3: vty_command (vty.c:482) ==63426== by 0x496948C: vty_execute (vty.c:1245) ==63426== by 0x496B2B4: vtysh_read (vty.c:2144) ==63426== by 0x496118F: thread_call (thread.c:2005) ==63426== by 0x48FF5E4: frr_run (libfrr.c:1198) ==63426== by 0x110CDC: main (sharp_main.c:192)

@donaldsharp Thanks for reporting these issues. I investigated a bit. The cause of these memory leaks is not related to this PR but to some other features already integrated in FRR, specifically the deallocation of the SRv6 locators and SRv6 nexthops. I opened another PR to fix these memory leaks (PR https://github.com/FRRouting/frr/pull/11855).

[cscarpitta]

I don't see anything beyond what Donald has already commented on ... will wait for those to be resolved and look again

@riw777 Thanks for the review. I already updated the PR with the implementation for all items highlighted by Donald Sharp.

[cscarpitta]

Rebased to resolve merge conflicts.

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7164/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2720: FILE: /tmp/f1-19364/rt_netlink.c:2720:
< WARNING: line over 80 characters
< #2723: FILE: /tmp/f1-19364/rt_netlink.c:2723:
< WARNING: Too many leading tabs - consider code refactoring
< #2725: FILE: /tmp/f1-19364/rt_netlink.c:2725:

[ton31337]

Can you rebase again?

[NetDEF-CI]

Continuous Integration Result: SUCCESSFUL

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7404/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Warnings Generated during build:

Checkout code: Successful with additional warnings

Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2720: FILE: /tmp/f1-10169/rt_netlink.c:2720:
< WARNING: line over 80 characters
< #2723: FILE: /tmp/f1-10169/rt_netlink.c:2723:
< WARNING: Too many leading tabs - consider code refactoring
< #2725: FILE: /tmp/f1-10169/rt_netlink.c:2725:

[cscarpitta]

Can you rebase again?

@ton31337 I rebased on master. Thanks.

[ton31337]

Let's wait until October 4, when the freeze ends.

[cscarpitta]

Hi @ton31337 @riw777 could we resume the work on this PR?

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7742/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Failed

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: No useful log found

Successful on other platforms/tests

• Ubuntu 20.04 amd64 build
• Ubuntu 22.04 amd64 build
• Ubuntu 18.04 arm8 build
• Debian 9 amd64 build
• Fedora 29 amd64 build
• Debian 10 amd64 build
• Ubuntu 16.04 arm7 build
• Ubuntu 18.04 arm7 build
• FreeBSD 11 amd64 build
• CentOS 7 amd64 build
• Ubuntu 16.04 i386 build
• Redhat 9 amd64 build
• Ubuntu 18.04 amd64 build
• Ubuntu 16.04 arm8 build
• Debian 11 amd64 build
• NetBSD 9 amd64 build
• OpenBSD 7 amd64 build
• Ubuntu 16.04 amd64 build
• FreeBSD 12 amd64 build
• Redhat 8 amd64 build
• Ubuntu 18.04 i386 build

Warnings Generated during build:

Checkout code: Successful with additional warnings

Ubuntu 18.04 ppc64le build: Failed (click for details)

Ubuntu 18.04 ppc64le build: No useful log found

<stdin>:14: trailing whitespace.
tests/topotests/srv6_encap_src_addr/test_srv6_encap_src_addr.py::test_zebra_srv6_encap_src_addr 
<stdin>:156: trailing whitespace.
tests/topotests/srv6_encap_src_addr/test_srv6_encap_src_addr.py::test_zebra_srv6_encap_src_addr_unset 
<stdin>:162: trailing whitespace.
	
<stdin>:167: trailing whitespace.
	        
<stdin>:223: trailing whitespace.
tests/topotests/srv6_encap_src_addr/test_srv6_encap_src_addr.py::test_zebra_srv6_encap_src_addr_set 
warning: squelched 51 whitespace errors
warning: 56 lines add whitespace errors.
Report for bgpd.c.rej | 4 issues
===============================================
ERROR: trailing whitespace
#6: FILE: /tmp/f1-3739766/bgpd.c.rej:6:
+ $
Report for bgp_network.c.rej | 12 issues
===============================================
ERROR: trailing whitespace
#16: FILE: /tmp/f1-3739766/bgp_network.c.rej:16:
+ $

ERROR: trailing whitespace
#18: FILE: /tmp/f1-3739766/bgp_network.c.rej:18:
+ $

ERROR: trailing whitespace
#28: FILE: /tmp/f1-3739766/bgp_network.c.rej:28:
+ $
Report for bgp_route.c.rej | 4 issues
===============================================
ERROR: trailing whitespace
#4: FILE: /tmp/f1-3739766/bgp_route.c.rej:4:
+ $
Report for bgp_vty.c.orig | 4 issues
===============================================
ERROR: trailing whitespace
#8902: FILE: /tmp/f1-3739766/bgp_vty.c.orig:8902:
+^I$
Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2720: FILE: /tmp/f1-3739766/rt_netlink.c:2720:
< WARNING: line over 80 characters
< #2723: FILE: /tmp/f1-3739766/rt_netlink.c:2723:
< WARNING: Too many leading tabs - consider code refactoring
< #2725: FILE: /tmp/f1-3739766/rt_netlink.c:2725:
Report for zebra_fpm_netlink.c.orig | 4 issues
===============================================
ERROR: trailing whitespace
#399: FILE: /tmp/f1-3739766/zebra_fpm_netlink.c.orig:399:
+^I^I^I$
Report for zebra_fpm_netlink.c.rej | 8 issues
===============================================
ERROR: trailing whitespace
#5: FILE: /tmp/f1-3739766/zebra_fpm_netlink.c.rej:5:
+ $

ERROR: trailing whitespace
#10: FILE: /tmp/f1-3739766/zebra_fpm_netlink.c.rej:10:
+ $

[NetDEF-CI]

Continuous Integration Result: FAILED

Continuous Integration Result: FAILED

Test incomplete. See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7743/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Addresssanitizer topotests part 3: Incomplete

(check logs for details)

Topotests Ubuntu 18.04 amd64 part 6: Incomplete

(check logs for details)

Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-7743/test

Topology Tests failed for Topotests debian 10 amd64 part 9 see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-7743/artifact/TOPO9DEB10AMD64/ErrorLog/log_topotests.txt

Successful on other platforms/tests

• Topotests Ubuntu 18.04 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 6
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 1
• Addresssanitizer topotests part 2
• Topotests Ubuntu 18.04 amd64 part 7
• Topotests debian 10 amd64 part 5
• Topotests Ubuntu 18.04 arm8 part 2
• Fedora 29 rpm pkg check
• Topotests Ubuntu 18.04 amd64 part 4
• CentOS 7 rpm pkg check
• Addresssanitizer topotests part 9
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 amd64 part 3
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 5
• Topotests Ubuntu 18.04 i386 part 0
• Addresssanitizer topotests part 6
• Ubuntu 18.04 deb pkg check
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 i386 part 3
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests Ubuntu 18.04 i386 part 8
• Addresssanitizer topotests part 0
• Topotests debian 10 amd64 part 8
• Debian 10 deb pkg check
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests Ubuntu 18.04 arm8 part 9
• Topotests Ubuntu 18.04 arm8 part 3
• Debian 9 deb pkg check
• Addresssanitizer topotests part 4
• Addresssanitizer topotests part 1
• Topotests Ubuntu 18.04 i386 part 4
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 arm8 part 0
• Topotests Ubuntu 18.04 amd64 part 9
• Topotests Ubuntu 18.04 i386 part 9
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests Ubuntu 18.04 arm8 part 7
• Static analyzer (clang)
• Addresssanitizer topotests part 7
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 amd64 part 5
• Ubuntu 16.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 1
• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 arm8 part 5

[NetDEF-CI]

Continuous Integration Result: FAILED

See below for issues. CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-7744/

This is a comment from an automated CI system. For questions and feedback in regards to this CI system, please feel free to email Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Failed

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Successful on other platforms/tests

• Topotests Ubuntu 18.04 arm8 part 6
• Topotests Ubuntu 18.04 amd64 part 0
• Topotests debian 10 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 1
• Topotests Ubuntu 18.04 amd64 part 7
• Addresssanitizer topotests part 2
• Topotests debian 10 amd64 part 0
• Topotests Ubuntu 18.04 arm8 part 2
• Addresssanitizer topotests part 3
• Topotests debian 10 amd64 part 5
• Addresssanitizer topotests part 9
• Topotests Ubuntu 18.04 amd64 part 4
• CentOS 7 rpm pkg check
• Fedora 29 rpm pkg check
• Topotests Ubuntu 18.04 i386 part 2
• Topotests Ubuntu 18.04 amd64 part 3
• Addresssanitizer topotests part 8
• Topotests Ubuntu 18.04 i386 part 7
• Topotests Ubuntu 18.04 arm8 part 8
• Topotests Ubuntu 18.04 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 5
• Addresssanitizer topotests part 6
• Topotests Ubuntu 18.04 i386 part 0
• Ubuntu 18.04 deb pkg check
• Topotests Ubuntu 18.04 amd64 part 2
• Topotests debian 10 amd64 part 7
• Topotests Ubuntu 18.04 i386 part 8
• Topotests Ubuntu 18.04 i386 part 3
• Topotests debian 10 amd64 part 8
• Addresssanitizer topotests part 0
• Debian 10 deb pkg check
• Topotests Ubuntu 18.04 arm8 part 4
• Topotests debian 10 amd64 part 3
• Topotests Ubuntu 18.04 amd64 part 6
• Topotests Ubuntu 18.04 arm8 part 3
• Debian 9 deb pkg check
• Addresssanitizer topotests part 4
• Addresssanitizer topotests part 1
• Topotests debian 10 amd64 part 9
• Topotests Ubuntu 18.04 i386 part 4
• Topotests debian 10 amd64 part 4
• Topotests Ubuntu 18.04 amd64 part 9
• Topotests debian 10 amd64 part 2
• Topotests Ubuntu 18.04 i386 part 9
• Topotests Ubuntu 18.04 arm8 part 7
• Addresssanitizer topotests part 7
• Static analyzer (clang)
• Topotests Ubuntu 18.04 amd64 part 5
• Ubuntu 16.04 deb pkg check
• Ubuntu 20.04 deb pkg check
• Addresssanitizer topotests part 5
• Topotests Ubuntu 18.04 amd64 part 8
• Topotests debian 10 amd64 part 1
• Topotests Ubuntu 18.04 i386 part 1
• Topotests Ubuntu 18.04 arm8 part 5
• Topotests Ubuntu 18.04 i386 part 6
• Topotests Ubuntu 18.04 arm8 part 0

Warnings Generated during build:

Checkout code: Successful with additional warnings

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details)

Topotests Ubuntu 18.04 arm8 part 9: No useful log found

Report for rt_netlink.c | 6 issues
===============================================
< WARNING: Too many leading tabs - consider code refactoring
< #2720: FILE: /tmp/f1-3868145/rt_netlink.c:2720:
< WARNING: line over 80 characters
< #2723: FILE: /tmp/f1-3868145/rt_netlink.c:2723:
< WARNING: Too many leading tabs - consider code refactoring
< #2725: FILE: /tmp/f1-3868145/rt_netlink.c:2725:

[cscarpitta]

ci:rerun failed test_ospfv3_single_area