Chaskin Saroff

Results 37 comments of Chaskin Saroff

I'd like to just throw in my support for undoing things other than delete. There's been a number of times where I've accidentally pasted a bunch of cells and it...

Can this be merged?

@makseq I would favor the current stroke overwriting old strokes on the pixels where they overlap. Does that make sense?

IMO dealing with the overlap at export time isn't really solving the problem. The annotators themselves need to see how the overlap is handled in the UI in real time...

They will see the strokes overlapping. If this feature is implemented at the export step it isn't visually clear that the latest stroke erases the previous stroke. Even if the...

@Sylcan I haven't investigated this further, but this seems like a pretty serious issue. Checking the content length header really doesn't solve this issue for the exact reason that you...

@LinusU 🎯 Yep, that's what I'm saying. Ideally, multer will end the http request(responding with a 413) when it has received more than `limits.fileSize` bytes. Instead, it waits to receive...

It's been some time, but IIRC that's the behavior. It's probably worthwhile to note that I was using the in-memory adapter. `storage: multer.memoryStorage()`. A small reproduction would probably yield more...

@LinusU What did you mean by "there is no way to tell the client to abort their upload and just accept the servers answer directly instead..." I'm not sure what...

> Because as far as I know, our implementation will simply throw away the bytes for each unit of data from the socket once the limit has been reached. If...