Simon Adorf comments

Results 128 comments of


                                            Simon Adorf

trafficstars

Add capability to use different allocators in cuML Python benchmarks

/merge

[BUG] DBSCAN crashed instantly with data having a large #rows

This bug is still present with version f00d38df8 .

[FEA] Isolation Forest implementation with FIL inference capability

@divyegala FIL is already out of experimental as of 25.04, #6728 is the adoption of new FIL in RF. We could thus close the issue immediately, however, the following MRE...

Properly support `feature_names_in_` on cuml estimators

Related to https://github.com/rapidsai/cuml/issues/5677 .

Properly support `feature_names_in_` on cuml estimators

Bug should be captured by the `cuml_accel_feature_names_in` xfail group: https://github.com/rapidsai/cuml/blob/23d2fb5ec64e937a924eb12bb91dd0cd5c523838/python/cuml/cuml/accel/tests/scikit-learn/xfail-list.yaml#L1334-L1341

Spectral Embedding

Blocked on https://github.com/rapidsai/cuvs/pull/871

Spectral Embedding

@jcrist Are your concerns on this PR addressed?

Spectral Embedding

@cjnolet I believe your concerns should be addressed, would you mind giving this another look?