Christopher Wilcox

Results 42 comments of Christopher Wilcox

This looks good to me also. I have asked some other folks that are more familiar with the emulator to take a look also, in case there is a hidden...

This is a reasonable point, have you considered using unique project ids per test (or per parallel group)?

Confirmed. Repro below, should be added to `datastore_test.go`. S0 Passes today, S1 fails with `/datastore/datastore_test.go:3076: putMutations(1): datastore: flattening nested structs leads to a slice of slices: field "IDs"` ``` func...

I have added tests that show the current behavior. I think this is might not be an error. I do understand it is odd that it works in one order...

> . It makes me wonder if there is a bug that is being accounted for where sub fields of an array field get flattened inadvertently if a previous field...

Thanks for the issue. I validated this should work, it is particular however. The type of the elements in `someSlice` is important. If it is a document reference it should...

@dragonsinth could you explain the problem this is solving? How does this change the user experience? And thanks for your recent contributions to bttest. They are appreciated, but I want...

@igorbernstein2 any idea if this was something on the backlog?

While going over the backlog of PRs I reviewed this again. Were these by chance here to satisfy an interface?

I think that is correct. The code linked to is the code that needs changing, and this issue may have been overly prescriptive in how to address :)