Christopher Wilcox comments

Results 42 comments of


Christopher Wilcox

Make `gcping` and gcping.com use the same method to calculate latency

Taking some notes: ### Web Version For 30 seconds, send pings on loop. Once 20 pings have occurred, shift old pings out, keeping the latest 20. Always toss out the...

Saving an empty Buffer throws an error.

What work remains to close this issue?

Saving an empty Buffer throws an error.

Update v7.0 of protobufjs is staged but not relased. https://github.com/protobufjs/protobuf.js/pull/1519

Add warning when inference used for Number types to Datastore types

I think we are going to decide to not warn, but just remove this functionality as stated in #760.

Add warning when inference used for Number types to Datastore types

Warning is less breaking to users than deprecation, and customers that use ints only will not experience the degraded experience. This warning is a smaller step and directs users to...

Cannot open file `app_engine_key.proto` after build with esbuild

@bcoe @alexander-fenster ?

Don't unwrap automatically for Number to Datastore Types

Going to block on this happening for a bit. Warning may be enough and is in PR, tracked by 759.

Don't unwrap automatically for Number to Datastore Types

I am rewording this as the approach has moved from removal to changing the default behavior. By default we shouldn't unwrap these. Int and Double , as of the pr...

[Bug] Query with filter on an integer column. (JS has number not int and float)

Note: Other language clients have similar behavior. ``` from google.cloud import datastore client = datastore.Client() kind = "test" id = "test_id" key = client.key(kind, id) entity = datastore.entity.Entity(key) entity['field'] =...

[Bug] Query with filter on an integer column. (JS has number not int and float)

I think the root of the problem is, at query filter creation time, the client has no knowledge of the type of the field being filtered. the type needs to...