Christian Trott

Results 80 issues of Christian Trott

This adds the atomic accessor we need to use for View with memory traits atomic. This returns the AtomicRef from desul that has the expanded interface to deal with stuff...

It still works in 4.3.01 but in develop a lot of the tests segfault when launched with more than one thread (export KOKKOS_NUM_THREADS=4). For example: ``` s1087574:build crtrott$ containers/unit_tests/Kokkos_ContainersUnitTest_Threads [==========]...

Bug

This introduces the new View implementation derived from BasicView. The new View implementation can be disabled via `-DKokkos_ENABLE_IMPL_VIEW_LEGACY=ON`. This option is also set to on if `-DKokkos_ENABLE_IMLP_MDSPAN=OFF` is set. Restrictions:...

### General idea: review public interface and suggest things we should deprecate - also check files associates with specific interfaces to see if there is accidental public stuff we didn't...

Deprecate

We changed OffsetView to be publicly derived from View instead of implementing all things explicitly. We should derive privately to avoid accidentally exposing things we shouldn't - not sure what...

In the BasicView PR (#7385) we ran into an issue at the end with OpenACC. The actual problem is hard to pin down. Two tests are under some conditions crashing...

Backend - OpenACC

### `ViewTraits` is a helper class for implementing `View` and related classes - it defines many of the primary typedefs of `View` - `View` publicly derived from `ViewTraits` - Most...

This is gonna be a somewhat random list of notes for things to fix/deprecate I encounter during the View->mdspan transition. - `DownCast` member function: not following naming convention, maybe rename...

Hoping this will skip build, because it doesn't work with C++17. What this does is replacing Kokkos::View implementation (in particular ViewMapping) with implementation details from mdspan. Basic structure is: View...

Just some random thoughts before we take this out of experimental: - make all the `int enums` tag classes - would enable `make_scatter_view(view,ScatterSum,ScatterAtomic,ScatterNonDuplicated)` - should this thing have `extent(..)`? -...

Enhancement